Can not use variables in addonTemplate for namespace filed of resources

[zhujian7]

Describe the bug
I have a addonTemplate yaml, in which I want to set the namespace of the addon agent deployment a variable so it can be rendered by the managedclusteraddon.spec.installnamespace when deploying the agent.

apiVersion: addon.open-cluster-management.io/v1alpha1
kind: AddOnTemplate
metadata:
  name: hello-template
spec:
  addonName: hello-template
  agentSpec:
      workload:
        manifests:
          - kind: Deployment
            apiVersion: apps/v1
            metadata:
              name: hello-template-agent
              namespace: "{{INSTALL_NAMESPACE}}"   // error
              labels:
                app: hello-template-agent
            spec:
              replicas: 1
              selector:
                matchLabels:
                  app: hello-template-agent
              template:
                metadata:
                  labels:
                    app: hello-template-agent
                spec:
                  serviceAccountName: hello-template-agent-sa
                  containers:
                    - name: helloworld-agent
                      image: quay.io/open-cluster-management/addon-examples
                      imagePullPolicy: IfNotPresent
                      args:
                        - "/helloworld_helm"
                        - "agent"
                        - "--cluster-name={{CLUSTER_NAME}}"
                        - "--addon-namespace=open-cluster-management-agent-addon"
                        - "--addon-name=hello-template"
                        - "--hub-kubeconfig={{HUB_KUBECONFIG}}"
                      env:
                        - name: LOG_LEVEL
                          value: "{{LOG_LEVEL}}" # addonDeploymentConfig variables

But when I tried to create this addonTemplate, I got:

The AddOnTemplate "hello-template" is invalid: spec.agentSpec.workload.manifests[0].metadata.namespace: Invalid value: "{{INSTALL_NAMESPACE}}": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')

To Reproduce

1. Create the above addontemplate yaml to a kubernetes cluster

Expected behavior
The addon template can be created successfully

Environment ie: OCM version, Kubernetes version and provider:
OCM version: the latest commit: 36e389c

Additional context

[github-actions]

This issue is stale because it has been open for 120 days with no activity. After 14 days of inactivity, it will be closed. Remove the stable label to prevent this issue from being closed.

[zhujian7]

With this PR #417, even if we can not use variables for the namespace, we can configure the namespace by an addonDeploymentConfig.

[qiujian16]

/close

[openshift-ci]

@qiujian16: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.