✨ Set install namespace of addonTemplate from config

[qiujian16]

Summary

Related issue(s)

Fixes #

[qiujian16]

/hold
/assign @zhujian7

still need e2e test.

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 62.42%. Comparing base (bcbe4d2) to head (6b893cb).
Report is 24 commits behind head on main.

Files	Patch %	Lines
pkg/addon/templateagent/decorator.go	80.51%	9 Missing and 6 partials ⚠️
pkg/addon/templateagent/template_agent.go	71.42%	2 Missing and 2 partials ⚠️
pkg/addon/templateagent/values.go	83.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   61.54%   62.42%   +0.87%     
==========================================
  Files         133      133              
  Lines       14078    11390    -2688     
==========================================
- Hits         8665     7110    -1555     
+ Misses       4664     3518    -1146     
- Partials      749      762      +13     

Flag	Coverage Δ
unit	62.42% <80.00%> (+0.87%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/addon/OWNERS [qiujian16]
• test/OWNERS [qiujian16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zhujian7]

Suggested change

	overrideValues = addonfactory.MergeValues(overrideValues, defaultValues)
	overrideValues = addonfactory.MergeValues(defaultValues, overrideValues)

[zhujian7]

nit: default values can not be overridden, there are some descriptions in the tests that are not precise, I can submit another PR to refactor it after this is merged.

[zhujian7]

/lgtm

[qiujian16]

/unhold

[zhujian7]

@qiujian16 I suggest that we add a :warning: to the PR title: ✨ ⚠️ Set install namespace of addonTemplate from config, and add some description to the PR summary to state the INSTALL_NAMESPACE is removed, and user can use downward API, etc.