-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign the KubeClientRegistrationConfig for addonTemplate API #280
Comments
This was referenced Sep 20, 2023
Merged
Merged
Merged
/close |
@zhujian7: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
TomerFi
pushed a commit
to TomerFi/OCM
that referenced
this issue
Sep 27, 2023
Signed-off-by: ldpliu <daliu@redhat.com> Signed-off-by: ldpliu <daliu@redhat.com>
TomerFi
pushed a commit
to TomerFi/OCM
that referenced
this issue
Sep 27, 2023
…-cluster-management-io#280) Signed-off-by: Wei Liu <liuweixa@redhat.com> Signed-off-by: Wei Liu <liuweixa@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now the KubeClientRegistrationConfig in addonTemplate API looks like:
We got some feedback:
RoleRef
field inHubPermissionConfig
is very confusing, users do not if this field is needed or not in different HubPermissionsBindingTypeCurrentCluster
, if the RoleRef refers to aRole
, it is very difficult to use as users need to create the role every time the addon is enabled for a managed cluster.So we need to reconsider/refactor the KubeClientRegistrationConfig for addonTemplate API, and it is better to finish/implement this in OCM 0.12.0
The text was updated successfully, but these errors were encountered: