🐛 Update permission config in addontemplate #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
=======================================
Coverage 61.09% 61.10%
=======================================
Files 129 129
Lines 13752 13761 +9
=======================================
+ Hits 8402 8408 +6
- Misses 4580 4581 +1
- Partials 770 772 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
zhujian7
changed the title
zhujian7
force-pushed
the
update-addontemplate
branch
from
23a9954 to
1664110
Compare
Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
update-addontemplate
branch
from
1664110 to
def00d9
Compare
|
cc @qiujian16 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-robot
merged commit e6443b6
into
open-cluster-management-io:main
12 checks passed
TomerFi
pushed a commit
to TomerFi/OCM
that referenced
this pull request
Sep 27, 2023
Signed-off-by: Zhiwei Yin <zyin@redhat.com> Signed-off-by: Zhiwei Yin <zyin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #
Issue reference: #280