Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local-up.sh #124

Conversation

xuezhaojun
Copy link
Member

Signed-off-by: xuezhaojun zxue@redhat.com

Signed-off-by: xuezhaojun <zxue@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and mikeshng January 17, 2023 06:55
@xuezhaojun
Copy link
Member Author

/assign @qiujian16

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d257cdd into open-cluster-management-io:main Jan 17, 2023
@xuezhaojun xuezhaojun deleted the update-local-up branch December 19, 2023 07:21
zhiweiyin318 pushed a commit to zhiweiyin318/ocm that referenced this pull request Oct 14, 2024
…en-cluster-management-io#613) (open-cluster-management-io#124)

* only read the first item when RawFeedbackJsonString is disabled

This is to ensure the backward compatible when the feature gate
is disabled



* Add a test for backward compatible



---------

Signed-off-by: Jian Qiu <jqiu@redhat.com>
Co-authored-by: Jian Qiu <jqiu@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants