🐛 move patch routine to copy crd #261
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
+ Coverage 60.70% 60.72% +0.02%
==========================================
Files 128 128
Lines 13640 13640
==========================================
+ Hits 8280 8283 +3
+ Misses 4596 4594 -2
+ Partials 764 763 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
qiujian16
force-pushed
the
refactor-patch
branch
2 times, most recently
from
5d79c1d to
2dfee2e
Compare
This can avoid redudant file generated in _output Signed-off-by: Jian Qiu <jqiu@redhat.com>
qiujian16
force-pushed
the
refactor-patch
branch
from
2dfee2e to
7b3fb6c
Compare
|
/lgtm |
openshift-merge-robot
merged commit 0f16de9
into
open-cluster-management-io:main
|
LGTM |
| @@ -64,7 +61,7 @@ update-csv: ensure-operator-sdk | |||
| rm ./deploy/cluster-manager/olm-catalog/cluster-manager/manifests/cluster-manager_v1_serviceaccount.yaml | |||
| rm ./deploy/klusterlet/olm-catalog/klusterlet/manifests/klusterlet_v1_serviceaccount.yaml | |||
|
|
|||
| verify-crds: patch-crd | |||
| verify-crds: | |||
There was a problem hiding this comment.
seems need to pass parameter $(YAML_PATCH) to hack/verify-crds.sh
This can avoid redudant file generated in _output
Summary
Related issue(s)
Fixes #