Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix make verify error #264

Conversation

haoqing0110
Copy link
Member

Summary

Related issue(s)

Fixes #261 error

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 4, 2023
Signed-off-by: haoqing0110 <qhao@redhat.com>
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (0f16de9) 60.72% compared to head (6ef2cd0) 60.71%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
- Coverage   60.72%   60.71%   -0.02%     
==========================================
  Files         128      128              
  Lines       13640    13658      +18     
==========================================
+ Hits         8283     8292       +9     
- Misses       4594     4601       +7     
- Partials      763      765       +2     
Flag Coverage Δ
unit 60.71% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 31f9059 into open-cluster-management-io:main Sep 5, 2023
12 checks passed
@haoqing0110 haoqing0110 deleted the br_fix-verify branch September 5, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants