Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Set install namespace of addonTemplate from config #417

Merged
merged 2 commits into from
Apr 22, 2024

Add an e2e test case

6b893cb
Select commit
Loading
Failed to load commit list.
Merged

✨ Set install namespace of addonTemplate from config #417

Add an e2e test case
6b893cb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 22, 2024 in 0s

62.42% (+0.87%) compared to bcbe4d2

View this Pull Request on Codecov

62.42% (+0.87%) compared to bcbe4d2

Details

Codecov Report

Attention: Patch coverage is 80.00000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 62.42%. Comparing base (bcbe4d2) to head (6b893cb).
Report is 24 commits behind head on main.

Files Patch % Lines
pkg/addon/templateagent/decorator.go 80.51% 9 Missing and 6 partials ⚠️
pkg/addon/templateagent/template_agent.go 71.42% 2 Missing and 2 partials ⚠️
pkg/addon/templateagent/values.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   61.54%   62.42%   +0.87%     
==========================================
  Files         133      133              
  Lines       14078    11390    -2688     
==========================================
- Hits         8665     7110    -1555     
+ Misses       4664     3518    -1146     
- Partials      749      762      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov