🐛 Refresh external managed token secret if service account ns changes #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhujian <jiazhu@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
==========================================
+ Coverage 62.58% 62.62% +0.03%
==========================================
Files 136 136
Lines 11504 11529 +25
==========================================
+ Hits 7200 7220 +20
- Misses 3536 3540 +4
- Partials 768 769 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @elgnay |
|
/lgtm |
|
/lgtm |
|
/unhold |
openshift-merge-bot
bot
merged commit 5313ff7
into
open-cluster-management-io:main
14 checks passed
zhujian7
added a commit
to zhujian7/ocm
that referenced
this pull request
Aug 30, 2024
…pen-cluster-management-io#458) Signed-off-by: zhujian <jiazhu@redhat.com>
openshift-merge-bot bot
pushed a commit
to stolostron/ocm
that referenced
this pull request
Sep 4, 2024
…s deleted (#117) * Refresh external managed token secret if service account ns changes (open-cluster-management-io#458) Signed-off-by: zhujian <jiazhu@redhat.com> * 🐛 Refresh external managed token secret if service account is deleted (open-cluster-management-io#504) (#78) * Refresh external managed token secret if service account is deleted * Debug e2e --------- Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/ocm
that referenced
this pull request
Sep 9, 2024
…pen-cluster-management-io#458) Signed-off-by: zhujian <jiazhu@redhat.com>
openshift-merge-bot bot
pushed a commit
to stolostron/ocm
that referenced
this pull request
Sep 10, 2024
…s deleted (#123) * Refresh external managed token secret if service account ns changes (open-cluster-management-io#458) Signed-off-by: zhujian <jiazhu@redhat.com> * 🐛 Refresh external managed token secret if service account is deleted (open-cluster-management-io#504) (#78) * Refresh external managed token secret if service account is deleted * Debug e2e --------- Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com> Co-authored-by: Jian Zhu <jiazhu@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes #