🐛 Refresh external managed token secret if service account is deleted #504
Conversation
| @@ -78,30 +79,6 @@ func SATokenGetter(ctx context.Context, saName, saNamespace string, saClient kub | |||
| } | |||
| } | |||
|
|
|||
| // SATokenCreater create the saToken of target sa. | |||
| func SATokenCreater(ctx context.Context, saName, saNamespace string, saClient kubernetes.Interface) TokenGetterFunc { | |||
There was a problem hiding this comment.
The SATokenGetter func contains logic in the SATokenCreater func, seems this is not necessary.
There was a problem hiding this comment.
/cc @zhiweiyin318 @xuezhaojun please take a look here
|
@zhujian7: GitHub didn't allow me to request PR reviews from the following users: please, take, a, look, here. Note that only open-cluster-management-io members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
zhujian7
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
==========================================
+ Coverage 62.15% 62.19% +0.03%
==========================================
Files 140 140
Lines 11770 11758 -12
==========================================
- Hits 7316 7313 -3
+ Misses 3683 3673 -10
- Partials 771 772 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/assign @elgnay |
Signed-off-by: zhujian <jiazhu@redhat.com>
zhujian7
force-pushed
the
refresh-token-uid
branch
from
8115497 to
3f0f3ae
Compare
zhujian7
force-pushed
the
refresh-token-uid
branch
from
3f0f3ae to
d06d29e
Compare
|
lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 00c39e2
into
open-cluster-management-io:main
…open-cluster-management-io#504) * Refresh external managed token secret if service account is deleted Signed-off-by: zhujian <jiazhu@redhat.com> * Debug e2e Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com>
…open-cluster-management-io#504) (#78) * Refresh external managed token secret if service account is deleted * Debug e2e --------- Signed-off-by: zhujian <jiazhu@redhat.com>
…open-cluster-management-io#504) (open-cluster-management-io#78) * Refresh external managed token secret if service account is deleted * Debug e2e --------- Signed-off-by: zhujian <jiazhu@redhat.com>
…s deleted (#117) * Refresh external managed token secret if service account ns changes (open-cluster-management-io#458) Signed-off-by: zhujian <jiazhu@redhat.com> * 🐛 Refresh external managed token secret if service account is deleted (open-cluster-management-io#504) (#78) * Refresh external managed token secret if service account is deleted * Debug e2e --------- Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com>
…open-cluster-management-io#504) (stolostron#78) * Refresh external managed token secret if service account is deleted * Debug e2e --------- Signed-off-by: zhujian <jiazhu@redhat.com>
…s deleted (#123) * Refresh external managed token secret if service account ns changes (open-cluster-management-io#458) Signed-off-by: zhujian <jiazhu@redhat.com> * 🐛 Refresh external managed token secret if service account is deleted (open-cluster-management-io#504) (#78) * Refresh external managed token secret if service account is deleted * Debug e2e --------- Signed-off-by: zhujian <jiazhu@redhat.com> --------- Signed-off-by: zhujian <jiazhu@redhat.com> Co-authored-by: Jian Zhu <jiazhu@redhat.com>
Summary
Compare the uid of the service account to check if the service account is recreated.
Related issue(s)
similar PR: #458
Fixes #503