🐛 igonre failed to get pullsecret error #463
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
=======================================
Coverage 62.64% 62.64%
=======================================
Files 136 136
Lines 11529 11529
=======================================
Hits 7222 7222
Misses 3539 3539
Partials 768 768
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -262,7 +262,7 @@ func (n *clusterManagerController) sync(ctx context.Context, controllerContext f | |||
| // check imagePulSecret here because there will be a warning event FailedToRetrieveImagePullSecret | |||
| // if imagePullSecret does not exist. | |||
| if config.ImagePullSecret, err = n.getImagePullSecret(ctx); err != nil { | |||
| return err | |||
| klog.Errorf("failed to get image pull secret: %v", err) | |||
There was a problem hiding this comment.
if this error will not result in running to fail, it should be Info or Warning level.
There was a problem hiding this comment.
ditto, also add a todo here that we should return err in the next release.
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
zhiweiyin318
force-pushed
the
ignore-pullsecret-err
branch
from
47cf3d6 to
1a45d98
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 319d9af
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #