Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 igonre failed to get pullsecret error #463

Merged
merged 1 commit into from
May 15, 2024
Merged

🐛 igonre failed to get pullsecret error #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...perators/clustermanager/controllers/clustermanagercontroller/clustermanager_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,9 @@ func (n *clusterManagerController) sync(ctx context.Context, controllerContext f
// check imagePulSecret here because there will be a warning event FailedToRetrieveImagePullSecret
// if imagePullSecret does not exist.
if config.ImagePullSecret, err = n.getImagePullSecret(ctx); err != nil {
return err
// may meet permission error in the upgrade case when the new rbac is not upgraded, so ignore err in this release.
// TODO: need return err if fail to get secret in the next release.
klog.Warningf("failed to get image pull secret: %v", err)
}

for _, reconciler := range reconcilers {
Expand Down
Loading