Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add well known status rule for daemonsets #518

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Jun 13, 2024

Summary

Related issue(s)

#368

Fixes #

Signed-off-by: zhujian <jiazhu@redhat.com>
@openshift-ci openshift-ci bot requested review from elgnay and zhiweiyin318 June 13, 2024 10:23
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.11%. Comparing base (8e5d1a1) to head (13fcce5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   62.10%   62.11%   +0.01%     
==========================================
  Files         141      141              
  Lines       11740    11744       +4     
==========================================
+ Hits         7291     7295       +4     
  Misses       3677     3677              
  Partials      772      772              
Flag Coverage Δ
unit 62.11% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zhujian <jiazhu@redhat.com>
@zhujian7 zhujian7 changed the title Add well known status rule for daemonsets ✨ Add well known status rule for daemonsets Jun 13, 2024
@zhujian7
Copy link
Member Author

/cc @qiujian16

@openshift-ci openshift-ci bot requested a review from qiujian16 June 14, 2024 00:15
@@ -541,4 +541,186 @@ var _ = ginkgo.Describe("ManifestWork Status Feedback", func() {
}, eventuallyTimeout, eventuallyInterval).ShouldNot(gomega.HaveOccurred())
})
})

ginkgo.Context("DaemonSet Status feedback", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skeeey why do we still need to create separated integration test case for cloudevent?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the could events supports single manifest, for single manifest, some integration cannot pass

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4a32909 into open-cluster-management-io:main Jun 14, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants