-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add well known status rule for daemonsets #518
✨ Add well known status rule for daemonsets #518
Conversation
Signed-off-by: zhujian <jiazhu@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 62.10% 62.11% +0.01%
==========================================
Files 141 141
Lines 11740 11744 +4
==========================================
+ Hits 7291 7295 +4
Misses 3677 3677
Partials 772 772
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: zhujian <jiazhu@redhat.com>
/cc @qiujian16 |
@@ -541,4 +541,186 @@ var _ = ginkgo.Describe("ManifestWork Status Feedback", func() { | |||
}, eventuallyTimeout, eventuallyInterval).ShouldNot(gomega.HaveOccurred()) | |||
}) | |||
}) | |||
|
|||
ginkgo.Context("DaemonSet Status feedback", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skeeey why do we still need to create separated integration test case for cloudevent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the could events supports single manifest, for single manifest, some integration cannot pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhujian7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4a32909
into
open-cluster-management-io:main
Summary
Related issue(s)
#368
Fixes #