Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Use release version for appVersion rather than trimmed version #661

Merged

Conversation

qiujian16
Copy link
Member

@qiujian16 qiujian16 commented Oct 21, 2024

Summary

Related issue(s)

Fixes ##662

Signed-off-by: Jian Qiu <jqiu@redhat.com>
@openshift-ci openshift-ci bot requested review from deads2k and jnpacker October 21, 2024 02:03
Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.00%. Comparing base (9181dbb) to head (f38b54a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #661   +/-   ##
=======================================
  Coverage   63.00%   63.00%           
=======================================
  Files         182      182           
  Lines       17604    17604           
=======================================
  Hits        11091    11091           
  Misses       5601     5601           
  Partials      912      912           
Flag Coverage Δ
unit 63.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member Author

/cherry-pick release-0.15

@openshift-cherrypick-robot

@qiujian16: once the present PR merges, I will cherry-pick it on top of release-0.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zhujian7
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2722d8c into open-cluster-management-io:main Oct 21, 2024
18 checks passed
@openshift-cherrypick-robot

@qiujian16: new pull request created: #663

In response to this:

/cherry-pick release-0.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants