Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.15] 🐛 Use release version for appVersion rather than trimmed version #663

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #661

/assign qiujian16

Signed-off-by: Jian Qiu <jqiu@redhat.com>
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.95%. Comparing base (6d68522) to head (ed28461).
Report is 1 commits behind head on release-0.15.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-0.15     #663      +/-   ##
================================================
- Coverage         64.10%   62.95%   -1.15%     
================================================
  Files               182      182              
  Lines             14282    17618    +3336     
================================================
+ Hits               9155    11091    +1936     
- Misses             4214     5614    +1400     
  Partials            913      913              
Flag Coverage Δ
unit 62.95% <ø> (-1.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7
Copy link
Member

/override "codecov/project"

Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

@zhujian7: zhujian7 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

/override "codecov/project"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiujian16
Copy link
Member

/override codecov/project

Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

@qiujian16: Overrode contexts on behalf of qiujian16: codecov/project

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 21, 2024
Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6c475a9 into open-cluster-management-io:release-0.15 Oct 21, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants