Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce flipt provider for dotnet #285

Merged
merged 43 commits into from
Oct 14, 2024

Conversation

jeandreidc
Copy link
Contributor

@jeandreidc jeandreidc commented Sep 27, 2024

Flipt.io provider for dotnet

Initial version of flipt.io provider for dotnet.

  • Created a new provider for OpenFeature for flipt.io in .net

Related Issues

None

Notes

  • Handles most of openFeature datatypes

Follow-up Tasks

  • Pending unit tests for FliptProvider.cs class
  • Support .net 6.0, right now it only supports .net 8.0

@jeandreidc jeandreidc closed this Oct 1, 2024
@jeandreidc jeandreidc reopened this Oct 1, 2024
@jeandreidc jeandreidc force-pushed the feature/flipt-client-for-dotnet branch 3 times, most recently from a116bd7 to 76d160e Compare October 1, 2024 11:19
@jeandreidc jeandreidc changed the title Feature/flipt client for dotnet feat: Introduce flipt provider for dotnet Oct 1, 2024
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
…dded handling of http exceptions thrown by flipt client

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
…per serialization to Dict<string, string>

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
…JSON settings

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
…oleans

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
…riant types

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc jeandreidc force-pushed the feature/flipt-client-for-dotnet branch from 722be51 to 10b1d86 Compare October 2, 2024 20:18
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc jeandreidc force-pushed the feature/flipt-client-for-dotnet branch from 478ac9b to d8d382d Compare October 2, 2024 20:58
…spec

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
…time, kept openapi.yaml in the solution

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
…nternal

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@markphelps
Copy link

Thanks again @jeandreidc !! Looks great!

cc @toddbaert

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
…rl command from build events

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@markphelps
Copy link

@beeme1mr @toddbaert is there anything else blocking this from merge?

Thanks again @jeandreidc !!

@beeme1mr
Copy link
Member

Approved, but there's an issue with the build. Feel free to ping me so I can retrigger CI once the issue has been addressed.

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Copy link
Contributor Author

Fixed the build issue please re-run the workflows, TIA! @beeme1mr

@beeme1mr beeme1mr merged commit 5cc83a1 into open-feature:main Oct 14, 2024
4 of 7 checks passed
@jeandreidc
Copy link
Contributor Author

Hello @beeme1mr was it merged by mistake? I was waiting for the build pipeline to pass

@beeme1mr
Copy link
Member

Yes, I thought the tests passed but apparently they hadn't started.

@beeme1mr
Copy link
Member

beeme1mr commented Oct 14, 2024

@jeandreidc sorry about that. Would you mind addressing the build issue in a separate pr? On the bright side, the ci should run automatically since it's no longer your first contribution 😀

We're going to revert the merge. Could you please open a new PR referencing this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants