Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce flipt provider for dotnet #293

Merged
merged 48 commits into from
Oct 17, 2024
Merged

feat: Introduce flipt provider for dotnet #293

merged 48 commits into from
Oct 17, 2024

Conversation

jeandreidc
Copy link
Contributor

PR to fix build issues that were found in #285

Flipt.io provider for dotnet

Initial version of flipt.io provider for dotnet.

  • Created a new provider for OpenFeature for flipt.io in .net
  • Fixed build issues by using nswag.dll instead of nswag command

Related Issues

None

Notes

  • Handles most of openFeature datatypes

@jeandreidc
Initial working commit without tests
97a5970 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Handle type mismatch and Value casting
c707b3e 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Added extension to map flipt context to openFeature, a…
ee902c6 
…dded handling of http exceptions thrown by flipt client

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Added xmldoc on extension function
656711b 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Added handling of different Value types, added tests to check for pro…
f17949b 
…per serialization to Dict<string, string>

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Added handling of array of Values, introduced universal deserializer …
7898c86 
…JSON settings

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Added support to serialize nested Values list
41cf5bf 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Add support for serializing structure
d94a6c6 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Implement Structure deserializer
d651b3c 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Rename ClientWrapper to converter
77afc27 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Implemented wrapper class, added unit tests
a9ca17f 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Code cleanup
d98f9ce 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Extracted Converter tests to its own file
48c555c 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Added unit tests for FliptToOpenFeature converter for variants and bo…
d4b3e42 
…oleans

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Added FliptToOpenFeatureConverter tests for non-existent flags for Va…
10b1d86 
…riant types

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Update release metadata
d8d382d 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Replaced Flipt package with a generated RestClient from their openapi…
204144f 
…spec

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Changed exception handling to use generated exceptions by nswag
563dd5f 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Modified unit test to throw mocked FliptExceptions
29077ea 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Utilized OpenFeature Reason type on Resolutions
e11bdaa 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Change test project setting; Cleaned FLiptConverter code
cd1b5a9 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Change types to support all .net target versions
83d0fde 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Update Readme
2417a9a 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Update ReadMe, test fliptClientWrapper calls
fd7210a 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Removed wrong code change in a different project
328c5a1 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
lint
0dcca7e 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Used HttpStatusCode.Ambiguous because TooManyRequests is not yet impl…
cc8a209 
…emented in .net 4.6

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Updated openapi.yaml src, regenerated RestClient using…
c3d28b8 
… new openapi spec, removed typos in readme, unit test updates

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Update readme instructions
6633132 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
reverted nuget.config changes, fix linting spacing issue caused by fo…
d8c4e85 
…rmatter

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Updated to throw exceptions instead of handling them a…
a5ed946 
…nd returning ResolutionDetails

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Moved client class generation and referencing in build…
81b5162 
…time, kept openapi.yaml in the solution

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Made constructor that receives a dependent interface i…
128c142 
…nternal

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
FliptProvider: Updated component_owners
05944bf 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Update readme
d491ef3 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Merge remote-tracking branch 'upstream/main' into feature/flipt-clien…
d17d2d8 
…t-for-dotnet
@jeandreidc
Reverted unintended lint changes to Flagsmith.csproj
2110460 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Fixed Nswag build time error, updated README, removed openapi.yaml cu…
062445a 
…rl command from build events

Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
lint changes in test
14a2223 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Merge remote-tracking branch 'upstream/main' into feature/flipt-clien…
3224b95 
…t-for-dotnet
@jeandreidc
Updated System.Text.Json to latest version
582a4fb 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Changed prebuild stage of nswag generation script
09dbc34 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Use nswag msbuild variables in creating clients
632210b 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc jeandreidc requested review from a team as code owners October 17, 2024 12:36
@jeandreidc
Fix System.Http reference in tests
92be761 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Fix import errors on dotnet version 462
06584f7 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Fix failing unit test caused by lint
6a1f64c 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
lint
5312d53 
Signed-off-by: Andrei de la Cruz <andrei.delacruz@gmail.com>
@jeandreidc
Copy link
Contributor Author

Got it working! @beeme1mr

markphelps
markphelps approved these changes Oct 17, 2024
View reviewed changes
Copy link

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! Thank you again @jeandreidc

@beeme1mr beeme1mr merged commit 4d59bc3 into open-feature:main Oct 17, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Merged
@beeme1mr beeme1mr mentioned this pull request Oct 17, 2024
Closed
@jeandreidc jeandreidc deleted the feature/flipt-client-for-dotnet branch October 18, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markphelps markphelps markphelps approved these changes

@beeme1mr beeme1mr beeme1mr approved these changes

@toddbaert toddbaert Awaiting requested review from toddbaert

Assignees

@markphelps markphelps

@jeandreidc jeandreidc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeandreidc @markphelps @beeme1mr