Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: Enable nullable reference types #253

Merged
merged 26 commits into from
Apr 5, 2024
Merged

chore!: Enable nullable reference types #253

merged 26 commits into from
Apr 5, 2024

Conversation

askpt
Copy link
Member

@askpt askpt commented Mar 28, 2024 •
edited
Loading

Enable nullable reference types

  • This PR enables the nullable validation and treats warnings as errors.

Related Issues

Fixes #208

Notes

This PR turns on the nullable checks for the dotnet checks. This gives us a better and safer codebase since it checks for potential null exceptions.

Breaking changes

While this PR won't require changes to the exposed API, it might show some errors to the clients consuming it.

@askpt askpt linked an issue Mar 28, 2024 that may be closed by this pull request
Enable Nullable Reference Types #208
Closed
askpt added 15 commits March 28, 2024 10:15
@askpt
Adding nullable support.
1becfbd 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Fix nullables for Exceptions.
865fa90 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Fix Extensions
f709fc4 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Adding Warning as error.
dda1e56 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Removed redundant compiler nullable.
211f8ca 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Fixes for Model.
46de1a4 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
More fixes for Model
0963611 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Added more nullable fixes.
63e6961 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
A few more fixes.
e8c0f7e 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
More fixes.
dbef345 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Adding safe check.
f6f2e2c 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Making name and version mandatory.
3bb15e5 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Last fix for the API.
0bedfd3 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Fix E2E tests.
45355d1 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Adding more nullable fixes.
3d21bd9 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt askpt force-pushed the askpt/208-enable-nullable-reference-types branch from 30e7a51 to 3d21bd9 Compare March 28, 2024 10:15
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.30769% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 95.50%. Comparing base (9b9c3fd) to head (0738213).

Files Patch % Lines
src/OpenFeature/EventExecutor.cs 66.66% 0 Missing and 4 partials ⚠️
src/OpenFeature/OpenFeatureClient.cs 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   94.47%   95.50%   +1.03%     
==========================================
  Files          27       27              
  Lines        1104     1113       +9     
  Branches      119      120       +1     
==========================================
+ Hits         1043     1063      +20     
+ Misses         37       33       -4     
+ Partials       24       17       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@askpt
Increase coverage.
44a0e3a 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Adding new unit test.
bbcbb37 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Adding more unit tests.
aa228bf 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Adding more unit tests.
15270f3 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt askpt force-pushed the askpt/208-enable-nullable-reference-types branch from d31f23e to 15270f3 Compare March 28, 2024 14:05
@askpt
Fix warnings.
ed23d41 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Fix for logging.
535fd21 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Adding more tests.
3530680 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Adding more unit tests.
fba7e84 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Updated logs.
fa7b425 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt askpt marked this pull request as ready for review March 28, 2024 15:51
@askpt askpt requested a review from a team as a code owner March 28, 2024 15:51
@askpt askpt added this to the 2.0 (breaking) milestone Mar 28, 2024
@askpt askpt requested a review from kinyoklion April 3, 2024 07:42
@askpt
Fix nullability issue in ProviderRepository.cs
0738213 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@beeme1mr beeme1mr requested a review from toddbaert April 5, 2024 13:10
@beeme1mr beeme1mr merged commit 5a5312c into main Apr 5, 2024
14 of 15 checks passed
@beeme1mr beeme1mr deleted the askpt/208-enable-nullable-reference-types branch April 5, 2024 17:32
@github-actions github-actions bot mentioned this pull request Apr 5, 2024
Merged
toddbaert added a commit that referenced this pull request Aug 21, 2024
@github-actions @toddbaert
chore(main): release 2.0.0 (#254)
10af6cc 
🤖 I have created a release *beep* *boop*
---


##
[2.0.0](v1.5.0...v2.0.0)
(2024-08-21)

Today we're announcing the release of the OpenFeature SDK for .NET,
v2.0! This release contains several ergonomic improvements to the SDK,
which .NET developers will appreciate. It also includes some performance
optimizations brought to you by the latest .NET primitives.

For details and migration tips, check out:
https://openfeature.dev/blog/dotnet-sdk-v2

### ⚠ BREAKING CHANGES

* domain instead of client name
([#294](#294))
* internally maintain provider status
([#276](#276))
* add CancellationTokens, ValueTasks hooks
([#268](#268))
* Use same type for flag metadata and event metadata
([#241](#241))
* Enable nullable reference types
([#253](#253))

### 🐛 Bug Fixes

* Add missing error message when an error occurred
([#256](#256))
([949d53c](949d53c))
* Should map metadata when converting from ResolutionDetails to
FlagEvaluationDetails
([#282](#282))
([2f8bd21](2f8bd21))


### ✨ New Features

* add CancellationTokens, ValueTasks hooks
([#268](#268))
([33154d2](33154d2))
* back targetingKey with internal map
([#287](#287))
([ccc2f7f](ccc2f7f))
* domain instead of client name
([#294](#294))
([4c0592e](4c0592e))
* Drop net7 TFM
([#284](#284))
([2dbe1f4](2dbe1f4))
* internally maintain provider status
([#276](#276))
([63faa84](63faa84))
* Use same type for flag metadata and event metadata
([#241](#241))
([ac7d7de](ac7d7de))


### 🧹 Chore

* cleanup code
([#277](#277))
([44cf586](44cf586))
* **deps:** Project file cleanup and remove unnecessary dependencies
([#251](#251))
([79def47](79def47))
* **deps:** update actions/upload-artifact action to v4.3.3
([#263](#263))
([7718649](7718649))
* **deps:** update actions/upload-artifact action to v4.3.4
([#278](#278))
([15189f1](15189f1))
* **deps:** update actions/upload-artifact action to v4.3.5
([#291](#291))
([00e99d6](00e99d6))
* **deps:** update codecov/codecov-action action to v4
([#227](#227))
([11a0333](11a0333))
* **deps:** update codecov/codecov-action action to v4.3.1
([#267](#267))
([ff9df59](ff9df59))
* **deps:** update codecov/codecov-action action to v4.5.0
([#272](#272))
([281295d](281295d))
* **deps:** update dependency benchmarkdotnet to v0.14.0
([#293](#293))
([aec222f](aec222f))
* **deps:** update dependency coverlet.collector to v6.0.2
([#247](#247))
([ab34c16](ab34c16))
* **deps:** update dependency coverlet.msbuild to v6.0.2
([#239](#239))
([e654222](e654222))
* **deps:** update dependency dotnet-sdk to v8.0.204
([#261](#261))
([8f82645](8f82645))
* **deps:** update dependency dotnet-sdk to v8.0.301
([#271](#271))
([acd0385](acd0385))
* **deps:** update dependency dotnet-sdk to v8.0.303
([#275](#275))
([871dcac](871dcac))
* **deps:** update dependency dotnet-sdk to v8.0.400
([#295](#295))
([bb4f352](bb4f352))
* **deps:** update dependency githubactionstestlogger to v2.4.1
([#274](#274))
([46c2b15](46c2b15))
* **deps:** update dependency microsoft.net.test.sdk to v17.10.0
([#273](#273))
([581ff81](581ff81))
* **deps:** update dotnet monorepo
([#218](#218))
([bc8301d](bc8301d))
* **deps:** update xunit-dotnet monorepo
([#262](#262))
([43f14cc](43f14cc))
* **deps:** update xunit-dotnet monorepo
([#279](#279))
([fb1cc66](fb1cc66))
* **deps:** update xunit-dotnet monorepo to v2.8.1
([#266](#266))
([a7b6d85](a7b6d85))
* Enable nullable reference types
([#253](#253))
([5a5312c](5a5312c))
* in-memory UpdateFlags to UpdateFlagsAsync
([#298](#298))
([390205a](390205a))
* prompt 2.0
([9b9c3fd](9b9c3fd))
* Support for determining spec support for the repo
([#270](#270))
([67a1a0a](67a1a0a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@kinyoklion kinyoklion kinyoklion approved these changes

@toddbaert toddbaert Awaiting requested review from toddbaert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0 (breaking)
Development

Successfully merging this pull request may close these issues.

Enable Nullable Reference Types
3 participants
@askpt @beeme1mr @kinyoklion