-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Enable nullable reference types #253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
30e7a51
to
3d21bd9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
+ Coverage 94.47% 95.50% +1.03%
==========================================
Files 27 27
Lines 1104 1113 +9
Branches 119 120 +1
==========================================
+ Hits 1043 1063 +20
+ Misses 37 33 -4
+ Partials 24 17 -7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
d31f23e
to
15270f3
Compare
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
beeme1mr
approved these changes
Apr 2, 2024
kinyoklion
reviewed
Apr 2, 2024
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
kinyoklion
approved these changes
Apr 4, 2024
toddbaert
added a commit
that referenced
this pull request
Aug 21, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.0](v1.5.0...v2.0.0) (2024-08-21) Today we're announcing the release of the OpenFeature SDK for .NET, v2.0! This release contains several ergonomic improvements to the SDK, which .NET developers will appreciate. It also includes some performance optimizations brought to you by the latest .NET primitives. For details and migration tips, check out: https://openfeature.dev/blog/dotnet-sdk-v2 ### ⚠ BREAKING CHANGES * domain instead of client name ([#294](#294)) * internally maintain provider status ([#276](#276)) * add CancellationTokens, ValueTasks hooks ([#268](#268)) * Use same type for flag metadata and event metadata ([#241](#241)) * Enable nullable reference types ([#253](#253)) ### 🐛 Bug Fixes * Add missing error message when an error occurred ([#256](#256)) ([949d53c](949d53c)) * Should map metadata when converting from ResolutionDetails to FlagEvaluationDetails ([#282](#282)) ([2f8bd21](2f8bd21)) ### ✨ New Features * add CancellationTokens, ValueTasks hooks ([#268](#268)) ([33154d2](33154d2)) * back targetingKey with internal map ([#287](#287)) ([ccc2f7f](ccc2f7f)) * domain instead of client name ([#294](#294)) ([4c0592e](4c0592e)) * Drop net7 TFM ([#284](#284)) ([2dbe1f4](2dbe1f4)) * internally maintain provider status ([#276](#276)) ([63faa84](63faa84)) * Use same type for flag metadata and event metadata ([#241](#241)) ([ac7d7de](ac7d7de)) ### 🧹 Chore * cleanup code ([#277](#277)) ([44cf586](44cf586)) * **deps:** Project file cleanup and remove unnecessary dependencies ([#251](#251)) ([79def47](79def47)) * **deps:** update actions/upload-artifact action to v4.3.3 ([#263](#263)) ([7718649](7718649)) * **deps:** update actions/upload-artifact action to v4.3.4 ([#278](#278)) ([15189f1](15189f1)) * **deps:** update actions/upload-artifact action to v4.3.5 ([#291](#291)) ([00e99d6](00e99d6)) * **deps:** update codecov/codecov-action action to v4 ([#227](#227)) ([11a0333](11a0333)) * **deps:** update codecov/codecov-action action to v4.3.1 ([#267](#267)) ([ff9df59](ff9df59)) * **deps:** update codecov/codecov-action action to v4.5.0 ([#272](#272)) ([281295d](281295d)) * **deps:** update dependency benchmarkdotnet to v0.14.0 ([#293](#293)) ([aec222f](aec222f)) * **deps:** update dependency coverlet.collector to v6.0.2 ([#247](#247)) ([ab34c16](ab34c16)) * **deps:** update dependency coverlet.msbuild to v6.0.2 ([#239](#239)) ([e654222](e654222)) * **deps:** update dependency dotnet-sdk to v8.0.204 ([#261](#261)) ([8f82645](8f82645)) * **deps:** update dependency dotnet-sdk to v8.0.301 ([#271](#271)) ([acd0385](acd0385)) * **deps:** update dependency dotnet-sdk to v8.0.303 ([#275](#275)) ([871dcac](871dcac)) * **deps:** update dependency dotnet-sdk to v8.0.400 ([#295](#295)) ([bb4f352](bb4f352)) * **deps:** update dependency githubactionstestlogger to v2.4.1 ([#274](#274)) ([46c2b15](46c2b15)) * **deps:** update dependency microsoft.net.test.sdk to v17.10.0 ([#273](#273)) ([581ff81](581ff81)) * **deps:** update dotnet monorepo ([#218](#218)) ([bc8301d](bc8301d)) * **deps:** update xunit-dotnet monorepo ([#262](#262)) ([43f14cc](43f14cc)) * **deps:** update xunit-dotnet monorepo ([#279](#279)) ([fb1cc66](fb1cc66)) * **deps:** update xunit-dotnet monorepo to v2.8.1 ([#266](#266)) ([a7b6d85](a7b6d85)) * Enable nullable reference types ([#253](#253)) ([5a5312c](5a5312c)) * in-memory UpdateFlags to UpdateFlagsAsync ([#298](#298)) ([390205a](390205a)) * prompt 2.0 ([9b9c3fd](9b9c3fd)) * Support for determining spec support for the repo ([#270](#270)) ([67a1a0a](67a1a0a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable nullable reference types
Related Issues
Fixes #208
Notes
This PR turns on the nullable checks for the dotnet checks. This gives us a better and safer codebase since it checks for potential null exceptions.
Breaking changes
While this PR won't require changes to the exposed API, it might show some errors to the clients consuming it.