feat: back targetingKey with internal map #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
commented
Jul 26, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
force-pushed
the
feat/expose-targeting-key-context
branch
from
fe6aa2a
to
d5f1e44
Compare
toddbaert
requested review from
beeme1mr,
benjiro,
askpt,
Kavindu-Dodan and
austindrenski
|
@Kavindu-Dodan adding you since you opened the issue and implemented it in Java. |
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
askpt
reviewed
Jul 29, 2024
Co-authored-by: André Silva <2493377+askpt@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
beeme1mr
approved these changes
Jul 29, 2024
toddbaert
added a commit
that referenced
this pull request
Jul 29, 2024
v1 backport of #287 --------- Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
added a commit
that referenced
this pull request
Aug 21, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.0](v1.5.0...v2.0.0) (2024-08-21) Today we're announcing the release of the OpenFeature SDK for .NET, v2.0! This release contains several ergonomic improvements to the SDK, which .NET developers will appreciate. It also includes some performance optimizations brought to you by the latest .NET primitives. For details and migration tips, check out: https://openfeature.dev/blog/dotnet-sdk-v2 ### ⚠ BREAKING CHANGES * domain instead of client name ([#294](#294)) * internally maintain provider status ([#276](#276)) * add CancellationTokens, ValueTasks hooks ([#268](#268)) * Use same type for flag metadata and event metadata ([#241](#241)) * Enable nullable reference types ([#253](#253)) ### 🐛 Bug Fixes * Add missing error message when an error occurred ([#256](#256)) ([949d53c](949d53c)) * Should map metadata when converting from ResolutionDetails to FlagEvaluationDetails ([#282](#282)) ([2f8bd21](2f8bd21)) ### ✨ New Features * add CancellationTokens, ValueTasks hooks ([#268](#268)) ([33154d2](33154d2)) * back targetingKey with internal map ([#287](#287)) ([ccc2f7f](ccc2f7f)) * domain instead of client name ([#294](#294)) ([4c0592e](4c0592e)) * Drop net7 TFM ([#284](#284)) ([2dbe1f4](2dbe1f4)) * internally maintain provider status ([#276](#276)) ([63faa84](63faa84)) * Use same type for flag metadata and event metadata ([#241](#241)) ([ac7d7de](ac7d7de)) ### 🧹 Chore * cleanup code ([#277](#277)) ([44cf586](44cf586)) * **deps:** Project file cleanup and remove unnecessary dependencies ([#251](#251)) ([79def47](79def47)) * **deps:** update actions/upload-artifact action to v4.3.3 ([#263](#263)) ([7718649](7718649)) * **deps:** update actions/upload-artifact action to v4.3.4 ([#278](#278)) ([15189f1](15189f1)) * **deps:** update actions/upload-artifact action to v4.3.5 ([#291](#291)) ([00e99d6](00e99d6)) * **deps:** update codecov/codecov-action action to v4 ([#227](
Use the internal dictionary for the
targetingKey.This is non-breaking from a compiler perspective. It could result in some behavioral changes, but IMO they are largely desirable.
Fixes: #235