feat: enable request logging via the --debug flag #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
james-milligan
requested review from
beeme1mr,
Kavindu-Dodan,
skyerus and
toddbaert
toddbaert
reviewed
Nov 28, 2022
toddbaert
approved these changes
Nov 28, 2022
|
To disable logging I have to pass |
AlexsJones
reviewed
Nov 29, 2022
We could have the request logging disabled by default and only enable it with the --debug flag? |
Sounds much better to me |
skyerus
reviewed
Nov 29, 2022
Signed-off-by: James Milligan <james@omnant.co.uk>
…into noop-logger
Signed-off-by: James Milligan <james@omnant.co.uk>
I have introduced this change |
james-milligan
changed the title
This makes sense to me as well. |
skyerus
reviewed
Nov 29, 2022
Co-authored-by: Skye Gill <gill.skye95@gmail.com> Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>
Co-authored-by: Skye Gill <gill.skye95@gmail.com> Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>
Co-authored-by: Skye Gill <gill.skye95@gmail.com> Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>
Co-authored-by: Skye Gill <gill.skye95@gmail.com> Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>
|
Is this ready for review now? |
yes :) |
|
@james-milligan please resolve conversations that have been addressed. |
Signed-off-by: James Milligan <james@omnant.co.uk>
AlexsJones
approved these changes
Dec 1, 2022
Signed-off-by: James Milligan <james@omnant.co.uk>
AlexsJones
approved these changes
Dec 1, 2022
AlexsJones
pushed a commit
that referenced
this pull request
Dec 5, 2022
🤖 I have created a release *beep* *boop* --- ## [0.2.7](v0.2.5...v0.2.7) (2022-12-02) ### ⚠ BREAKING CHANGES * start command flag refactor ([#222](#222)) ### Features * enable request logging via the --debug flag ([#226](#226)) ([11954b5](11954b5)) * Resurrected the STATIC flag reason. Documented the caching strategy. ([#224](#224)) ([5830592](5830592)) * snap ([#211](#211)) ([c619844](c619844)) * start command flag refactor ([#222](#222)) ([14474cc](14474cc)) ### Miscellaneous Chores * release v0.2.6 ([93cfb78](93cfb78)) * release v0.2.7 ([4a9f6df](4a9f6df)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
--debugflag now also controls the logging for requests, when set all logging levels are enabled for theXXXWithIDloggermethods and allows the setting of request fields, allowing for improved performance when logs are not required.NewLoggernow takes an additional boolean argument to set the internalreqIDLoggingfield, this field is also set to false when the*zap.Loggerargument is nilRelated Issues
Notes
Follow-up Tasks
This flag should be set by default in the operator
open-feature/open-feature-operator#260
How to test