Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use event.Has func for file change notification handling (increased stability across OS) #361

Merged

Conversation

skyerus
Copy link
Contributor

@skyerus skyerus commented Feb 1, 2023

This PR

Related Issues

Fixes #313

Notes

Follow-up Tasks

How to test

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@beeme1mr beeme1mr self-requested a review February 1, 2023 18:03
@beeme1mr
Copy link
Member

beeme1mr commented Feb 1, 2023

I still don't understand why this change increases stability across OSes.

@toddbaert
Copy link
Member

I still don't understand why this change increases stability across OSes.

@beeme1mr I added a comment to @skyerus 's change that should explain it.

skyerus and others added 4 commits February 1, 2023 14:07
…sed stability across OS)

Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Co-authored-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Co-authored-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com>
@toddbaert toddbaert force-pushed the issue-313/file-change-notifications branch from 5a90da5 to 1536a9c Compare February 1, 2023 19:07
Signed-off-by: Todd Baert <toddbaert@gmail.com>
@toddbaert toddbaert merged commit 09f74b9 into open-feature:main Feb 1, 2023
@skyerus skyerus deleted the issue-313/file-change-notifications branch February 2, 2023 13:35
skyerus pushed a commit that referenced this pull request Feb 6, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.3.5](v0.3.4...v0.3.5)
(2023-02-06)


### Features

* flagd image signing
([#338](#338))
([eca6a60](eca6a60))
* update in logging to console and Unify case usage, seperators and
punctuation for logging
([#322](#322))
([0bdcfd2](0bdcfd2))


### Bug Fixes

* **deps:** update module github.com/bufbuild/connect-go to v1.5.1
([#365](#365))
([e25f452](e25f452))
* **deps:** update module github.com/open-feature/open-feature-operator
to v0.2.28 ([#342](#342))
([e6df80f](e6df80f))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.14.2
([#336](#336))
([836d3cf](836d3cf))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.14.3
([#372](#372))
([330ac91](330ac91))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.14.4
([#374](#374))
([d90e561](d90e561))
* fix unbuffered channel blocking goroutine
([#358](#358))
([4f1905a](4f1905a))
* introduced RWMutex to flag state to prevent concurrent r/w of map
([#370](#370))
([93e356b](93e356b))
* use event.Has func for file change notification handling (increased
stability across OS)
([#361](#361))
([09f74b9](09f74b9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] File change notifications behaviour is inconsistent (OS specific)
4 participants