feat: update in logging to console and Unify case usage, seperators and punctuation for logging #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Mittal <105881639+mihirm21@users.noreply.github.com>
mihirm21
requested review from
AlexsJones,
james-milligan and
toddbaert
as code owners
mihirm21
changed the title
mihirm21
changed the title
Signed-off-by: Mihir Mittal <105881639+mihirm21@users.noreply.github.com>
|
It looks like the PR is failing on linting and tests, please can you resolve these issues. It also might be more appropriate to move the changes from commit |
Signed-off-by: Mihir Mittal <105881639+mihirm21@users.noreply.github.com>
mihirm21
changed the title
beeme1mr
requested changes
Jan 26, 2023
|
Also, please run |
Signed-off-by: Mihir Mittal <105881639+mihirm21@users.noreply.github.com>
|
plz review it |
mihirm21
requested review from
james-milligan and
beeme1mr
and removed request for
james-milligan and
beeme1mr
Signed-off-by: Mihir Mittal <105881639+mihirm21@users.noreply.github.com>
Signed-off-by: Mihir Mittal <105881639+mihirm21@users.noreply.github.com>
mihirm21
requested review from
james-milligan
and removed request for
beeme1mr
|
@james-milligan plz see now |
james-milligan
approved these changes
Jan 30, 2023
skyerus
approved these changes
Jan 30, 2023
beeme1mr
approved these changes
Jan 30, 2023
3 tasks
|
The OFO should be updated once this feature is available. |
|
Thank you for your contribution @mihirm21! This feature will be available in the next release. |
skyerus
pushed a commit
that referenced
this pull request
Feb 6, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.5](v0.3.4...v0.3.5) (2023-02-06) ### Features * flagd image signing ([#338](#338)) ([eca6a60](eca6a60)) * update in logging to console and Unify case usage, seperators and punctuation for logging ([#322](#322)) ([0bdcfd2](0bdcfd2)) ### Bug Fixes * **deps:** update module github.com/bufbuild/connect-go to v1.5.1 ([#365](#365)) ([e25f452](e25f452)) * **deps:** update module github.com/open-feature/open-feature-operator to v0.2.28 ([#342](#342)) ([e6df80f](e6df80f)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.14.2 ([#336](#336)) ([836d3cf](836d3cf)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.14.3 ([#372](#372)) ([330ac91](330ac91)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.14.4 ([#374](#374)) ([d90e561](d90e561)) * fix unbuffered channel blocking goroutine ([#358](#358)) ([4f1905a](4f1905a)) * introduced RWMutex to flag state to prevent concurrent r/w of map ([#370](#370)) ([93e356b](93e356b)) * use event.Has func for file change notification handling (increased stability across OS) ([#361](#361)) ([09f74b9](09f74b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihir Mittal 105881639+mihirm21@users.noreply.github.com
This PR
Related Issues
[FEATURE] Pretty-print logging #237
[REFACTOR] Unify case usage, seperators and punctuation for logging #298