fix: use event.Has func for file change notification handling (increased stability across OS) #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyerus
requested review from
AlexsJones,
james-milligan and
toddbaert
as code owners
james-milligan
approved these changes
Feb 1, 2023
|
I still don't understand why this change increases stability across OSes. |
toddbaert
reviewed
Feb 1, 2023
toddbaert
reviewed
Feb 1, 2023
toddbaert
reviewed
Feb 1, 2023
…sed stability across OS) Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Co-authored-by: Todd Baert <toddbaert@gmail.com> Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Co-authored-by: Todd Baert <toddbaert@gmail.com> Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com>
toddbaert
force-pushed
the
issue-313/file-change-notifications
branch
from
5a90da5
to
1536a9c
Compare
Signed-off-by: Todd Baert <toddbaert@gmail.com>
skyerus
pushed a commit
that referenced
this pull request
Feb 6, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.5](v0.3.4...v0.3.5) (2023-02-06) ### Features * flagd image signing ([#338](#338)) ([eca6a60](eca6a60)) * update in logging to console and Unify case usage, seperators and punctuation for logging ([#322](#322)) ([0bdcfd2](0bdcfd2)) ### Bug Fixes * **deps:** update module github.com/bufbuild/connect-go to v1.5.1 ([#365](#365)) ([e25f452](e25f452)) * **deps:** update module github.com/open-feature/open-feature-operator to v0.2.28 ([#342](#342)) ([e6df80f](e6df80f)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.14.2 ([#336](#336)) ([836d3cf](836d3cf)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.14.3 ([#372](#372)) ([330ac91](330ac91)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.14.4 ([#374](#374)) ([d90e561](d90e561)) * fix unbuffered channel blocking goroutine ([#358](#358)) ([4f1905a](4f1905a)) * introduced RWMutex to flag state to prevent concurrent r/w of map ([#370](#370)) ([93e356b](93e356b)) * use event.Has func for file change notification handling (increased stability across OS) ([#361](#361)) ([09f74b9](09f74b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #313
Notes
Follow-up Tasks
How to test