fix: otel hook attribute naming correction (#359)

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
open-feature · Jul 19, 2023 · 5e6ab32 · 5e6ab32
1 parent 4e1f46f
commit 5e6ab32
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/hooks/open-telemetry/pom.xml b/hooks/open-telemetry/pom.xml
@@ -45,6 +45,13 @@
             <scope>provided</scope>
         </dependency>
 
+        <dependency>
+            <groupId>io.opentelemetry</groupId>
+            <artifactId>opentelemetry-semconv</artifactId>
+            <version>1.28.0-alpha</version>
+            <scope>provided</scope>
+        </dependency>
+
         <dependency>
             <groupId>io.opentelemetry</groupId>
             <artifactId>opentelemetry-api</artifactId>

diff --git a/hooks/open-telemetry/src/main/java/dev/openfeature/contrib/hooks/otel/OTelCommons.java b/hooks/open-telemetry/src/main/java/dev/openfeature/contrib/hooks/otel/OTelCommons.java
@@ -1,14 +1,16 @@
 package dev.openfeature.contrib.hooks.otel;
 
 import io.opentelemetry.api.common.AttributeKey;
+import io.opentelemetry.semconv.trace.attributes.SemanticAttributes;
 
 class OTelCommons {
     // Define semantic conventions
     // Refer - https://opentelemetry.io/docs/specs/otel/logs/semantic_conventions/feature-flags/
     static final String EVENT_NAME = "feature_flag";
-    static final AttributeKey<String> flagKeyAttributeKey = AttributeKey.stringKey(EVENT_NAME + ".flag_key");
-    static final AttributeKey<String> providerNameAttributeKey = AttributeKey.stringKey(EVENT_NAME + ".provider_name");
-    static final AttributeKey<String> variantAttributeKey = AttributeKey.stringKey(EVENT_NAME + ".variant");
+
+    static final AttributeKey<String> flagKeyAttributeKey = SemanticAttributes.FEATURE_FLAG_KEY;
+    static final AttributeKey<String> providerNameAttributeKey = SemanticAttributes.FEATURE_FLAG_PROVIDER_NAME;
+    static final AttributeKey<String> variantAttributeKey = SemanticAttributes.FEATURE_FLAG_VARIANT;
 
     // Define non convention attribute keys
     static final String REASON_KEY = "reason";

diff --git a/hooks/open-telemetry/src/test/java/dev/openfeature/contrib/hooks/otel/TracesHookTest.java b/hooks/open-telemetry/src/test/java/dev/openfeature/contrib/hooks/otel/TracesHookTest.java
@@ -36,7 +36,7 @@ public static void close() {
         mockedSpan.close();
     }
 
-    private final AttributeKey<String> flagKeyAttributeKey = AttributeKey.stringKey("feature_flag.flag_key");
+    private final AttributeKey<String> flagKeyAttributeKey = AttributeKey.stringKey("feature_flag.key");
     private final AttributeKey<String> providerNameAttributeKey = AttributeKey.stringKey("feature_flag.provider_name");
     private final AttributeKey<String> variantAttributeKey = AttributeKey.stringKey("feature_flag.variant");