Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: otel hook attribute naming correction #359

Merged

Conversation

Kavindu-Dodan
Copy link
Collaborator

This PR

Corrects telemetry attribute key from feature_flag.flag_key to feature_flag.key. This is to match the naming with OTel semconv for feature falgs [1]

[1] - https://opentelemetry.io/docs/specs/otel/logs/semantic_conventions/feature-flags/

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@Kavindu-Dodan Kavindu-Dodan merged commit 5e6ab32 into open-feature:main Jul 19, 2023
4 checks passed
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
…ure#359)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants