-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CustomOps] TensorRT Gather Topk Ops #1033
Conversation
convert: test: |
@irexyc fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test with faster-rcnn and retinanet
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1033 +/- ##
==========================================
- Coverage 49.59% 49.51% -0.09%
==========================================
Files 305 305
Lines 10732 10758 +26
Branches 1602 1609 +7
==========================================
+ Hits 5323 5327 +4
- Misses 5030 5051 +21
- Partials 379 380 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Might be disabled after NVIDIA provide a fix.
Motivation
The dynamic batch detector failed because NVIDIA/TensorRT#2299.
Modification
Add custom ops for gather topk.
old:
new:
Add shape info, ut, docs, etc.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist