Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Refactor rewriter context for MMRazor #1483

Merged
merged 10 commits into from
Dec 13, 2022

Conversation

grimoire
Copy link
Member

@grimoire grimoire commented Dec 3, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Refactor rewriter for #1471
ctx has been removed from arguments.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@grimoire
Copy link
Member Author

grimoire commented Dec 3, 2022

@pppppM please take a look.

@RunningLeon
Copy link
Collaborator

RunningLeon commented Dec 5, 2022

@grimoire hi, this PR would affect the deployment of mmyolo, may let @hhaAndroid be aware of this.

@grimoire grimoire requested a review from hhaAndroid December 5, 2022 07:10
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hanrui1sensetime hanrui1sensetime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lvhan028
Copy link
Collaborator

lvhan028 commented Dec 7, 2022

1.x is mmdeploy's release branch while dev-1.x is its developing branch.
So please change the target branch to open-mmlab:dev-1.x

@grimoire grimoire changed the base branch from 1.x to dev-1.x December 7, 2022 10:33
@RunningLeon RunningLeon requested a review from lvhan028 December 8, 2022 02:15
@lvhan028
Copy link
Collaborator

lvhan028 commented Dec 8, 2022

@pppppM any comments?

@pppppM
Copy link
Contributor

pppppM commented Dec 9, 2022

@pppppM any comments?

@lvhan028 There is only a small problem, which has been solved with the help of @grimoire .

I have tested this PR with MMRazor quantized model.
This PR meets MMRazor needs.

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

@lvhan028 lvhan028 merged commit 3f261e6 into open-mmlab:dev-1.x Dec 13, 2022
lvhan028 pushed a commit that referenced this pull request Mar 1, 2023
* wip

* update rewriter

* Support all codebase

* update docs

* fix ssd

* rename qualname

* support torch.fx.wrap

* import by torch version

Co-authored-by: pppppM <gjf_mail@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants