Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Remove 'context' argument from the rewriter function to 'YOLOv5Head.p… #395

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

lvhan028
Copy link
Contributor

…redict_by_feat' since mmdeploy has refactored it

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

MMDeploy has refactored the rewriter function signature to support MMRazor, referring to open-mmlab/mmdeploy#1483,
in which the context argument has been removed from the argument list and can be retrieved by ctx = FUNCTION_REWRITER.get_context()

Modification

the rewriter function to YOLOv5Head.predict_by_feat

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a potential influence on downstream projects, this PR should be tested with downstream projects, like MMDetection or MMClassification.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

…redict_by_feat' since mmdeploy has refactored it
@lvhan028 lvhan028 changed the title remove 'context' argument from the rewriter function to 'YOLOv5Head.p… 【enhancement】remove 'context' argument from the rewriter function to 'YOLOv5Head.p… Dec 20, 2022
@lvhan028 lvhan028 changed the title 【enhancement】remove 'context' argument from the rewriter function to 'YOLOv5Head.p… 【Enhancement】remove 'context' argument from the rewriter function to 'YOLOv5Head.p… Dec 20, 2022
@CLAassistant
Copy link

CLAassistant commented Dec 20, 2022

CLA assistant check
All committers have signed the CLA.

@RangeKing RangeKing added the enhancement New feature or request label Dec 20, 2022
@PeterH0323 PeterH0323 changed the title 【Enhancement】remove 'context' argument from the rewriter function to 'YOLOv5Head.p… [Enhancement] Remove 'context' argument from the rewriter function to 'YOLOv5Head.p… Dec 20, 2022
@PeterH0323 PeterH0323 changed the base branch from main to dev December 20, 2022 11:22
Copy link
Collaborator

@PeterH0323 PeterH0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RangeKing
Copy link
Collaborator

Hi @lvhan028, thanks for your contribution. Please sign the CLA.

@lvhan028
Copy link
Contributor Author

Hi @lvhan028, thanks for your contribution. Please sign the CLA.

done

@hhaAndroid hhaAndroid merged commit cccc792 into open-mmlab:dev Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants