-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix bug in non-distributed multi-gpu training/testing #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tai-Wang
approved these changes
Jan 26, 2022
ZwwWayne
approved these changes
Jan 26, 2022
filaPro
added a commit
to filaPro/mmdetection3d
that referenced
this pull request
Feb 23, 2022
* Bump to v0.18.0 (open-mmlab#1148) * Update README & getting_started & changelog & version.py * resolve comments * Update the required maximum version of mmcv-full * Update changelog.md * Update getting_started.md * Add highlight in changelog.md * update imvoxelnet citation (open-mmlab#1153) * deprecate the support for "python setup.py test" (open-mmlab#1164) * add OpenMMLab website and platform links (open-mmlab#1176) * [Fix] Update regnet metafile (open-mmlab#1184) * update regnet metafile * Add Architechture in RegNet metafile * fix axis=0 rotation in master branch (open-mmlab#1182) * [Enhance] support semantic seg in Flip3D augmentation (open-mmlab#1181) * support semantic seg in flip * change box_dtype_3d to bbox3d_fields * add point cloud annotation in doc (open-mmlab#1185) * [Fix] Fix bug in non-distributed multi-gpu training/testing (open-mmlab#1197) * Fix bug in non-distributed multi-gpu training/testing * add deprecated warning to void BC-breaking * Add missing explanation of cam_intrinsic in the nuScenes dataset doc (open-mmlab#1193) * [Fix] Fix corner bug in different coordinates (open-mmlab#1212) * fix corner bug in cam coord * fix corner bugs in depth & lidar coord * Bump to v0.18.1 (open-mmlab#1218) * bump to v0.18.1 * fix comments * update bazel version (open-mmlab#1223) * [Fix] fix pointpillars bug on kitti in master branch (open-mmlab#1163) * fix pointpillars bug on kitti in master branch * replace with AlignedAnchorGenerator * Update the installation of MMCV (open-mmlab#1226) * [Fix] Fix a potential overflow bug when post_max_size is set too large in the circle_nms (open-mmlab#1225) * [Fix] overflow bug * [Fix] typo Co-authored-by: zeyuzeng <zeyuzeng@autox.ai> Co-authored-by: zeyu-hello <zeyuzeng@hotmail.com> * Fix PointRCNN bugs (open-mmlab#1224) * fix bug to allow pointnet to train in fp16 (open-mmlab#1207) * fix bug to allow pointnet to train in fp16 * remove unused import * fix lint * fix lint for gather_points_cuda.cu Co-authored-by: peng <maskjp@tamu.edu> * [Fix] Recheck import sorting (open-mmlab#1242) * fix missed mmcv * reinstall pre-commit and recheck * fix inference_demo.ipynb bug (open-mmlab#1236) * [Enhance] upgrade PointPillars performace on dev branch (open-mmlab#1166) * upgrade PointPillars performace on dev branch * update DynamicPillarFeatureNet * fix comments * change to AlignedAnchor3DRangeGenerator * change to AlignedAnchor3DRangeGenerator * fix * replace with AlignedAnchorGenerator * fix lint * update using isort * Bump to v1.0.0.rc0 (open-mmlab#928) * [Refactor] Main code modification for coordinate system refactor (open-mmlab#677) * [Enhance] Add script for data update (open-mmlab#774) * Fixed wrong config paths and fixed a bug in test * Fixed metafile * Coord sys refactor (main code) * Update test_waymo_dataset.py * Manually resolve conflict * Removed unused lines and fixed imports * remove coord2box and box2coord * update dir_limit_offset * Some minor improvements * Removed some \s in comments * Revert a change * Change Box3DMode to Coord3DMode where points are converted * Fix points_in_bbox function * Fix Imvoxelnet config * Revert adding a line * Fix rotation bug when batch size is 0 * Keep sign of dir_scores as before * Fix several comments * Add a comment * Fix docstring * Add data update scripts * Fix comments * fix import (open-mmlab#839) * [Enhance] refactor iou_neg_piecewise_sampler.py (open-mmlab#842) * [Refactor] Main code modification for coordinate system refactor (open-mmlab#677) * [Enhance] Add script for data update (open-mmlab#774) * Fixed wrong config paths and fixed a bug in test * Fixed metafile * Coord sys refactor (main code) * Update test_waymo_dataset.py * Manually resolve conflict * Removed unused lines and fixed imports * remove coord2box and box2coord * update dir_limit_offset * Some minor improvements * Removed some \s in comments * Revert a change * Change Box3DMode to Coord3DMode where points are converted * Fix points_in_bbox function * Fix Imvoxelnet config * Revert adding a line * Fix rotation bug when batch size is 0 * Keep sign of dir_scores as before * Fix several comments * Add a comment * Fix docstring * Add data update scripts * Fix comments * fix import * refactor iou_neg_piecewise_sampler.py * add docstring * modify docstring Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> * [Feature] Add roipooling cuda ops (open-mmlab#843) * [Refactor] Main code modification for coordinate system refactor (open-mmlab#677) * [Enhance] Add script for data update (open-mmlab#774) * Fixed wrong config paths and fixed a bug in test * Fixed metafile * Coord sys refactor (main code) * Update test_waymo_dataset.py * Manually resolve conflict * Removed unused lines and fixed imports * remove coord2box and box2coord * update dir_limit_offset * Some minor improvements * Removed some \s in comments * Revert a change * Change Box3DMode to Coord3DMode where points are converted * Fix points_in_bbox function * Fix Imvoxelnet config * Revert adding a line * Fix rotation bug when batch size is 0 * Keep sign of dir_scores as before * Fix several comments * Add a comment * Fix docstring * Add data update scripts * Fix comments * fix import * add roipooling cuda ops * add roi extractor * add test_roi_extractor unittest * Modify setup.py to install roipooling ops * modify docstring * remove enlarge bbox in roipoint pooling * add_roipooling_ops * modify docstring Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> * [Refactor] Refactor code structure and docstrings (open-mmlab#803) * refactor points_in_boxes * Merge same functions of three boxes * More docstring fixes and unify x/y/z size * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Remove None in function param type * Fix unittest * Add comments for NMS functions * Merge methods of Points * Add unittest * Add optional and default value * Fix box conversion and add unittest * Fix comments * Add unit test * Indent * Fix CI * Remove useless \\ * Remove useless \\ * Remove useless \\ * Remove useless \\ * Remove useless \\ * Add unit test for box bev * More unit tests and refine docstrings in box_np_ops * Fix comment * Add deprecation warning * [Feature] PointXYZWHLRBBoxCoder (open-mmlab#856) * support PointBasedBoxCoder * fix unittest bug * support unittest in gpu * support unittest in gpu * modified docstring * add args * add args * [Enhance] Change Groupfree3D config (open-mmlab#855) * All mods * PointSample * PointSample * [Doc] Add tutorials/data_pipeline Chinese version (open-mmlab#827) * [Doc] Add tutorials/data_pipeline Chinese version * refine doc * Use the absolute link * Use the absolute link Co-authored-by: Tai-Wang <tab_wang@outlook.com> * [Doc] Add Chinese doc for `scannet_det.md` (open-mmlab#836) * Part * Complete * Fix comments * Fix comments * [Doc] Add Chinese doc for `waymo_det.md` (open-mmlab#859) * Add complete translation * Refinements * Fix comments * Fix a minor typo Co-authored-by: Tai-Wang <tab_wang@outlook.com> * Remove 2D annotations on Lyft (open-mmlab#867) * Add header for files (open-mmlab#869) * Add header for files * Add header for files * Add header for files * Add header for files * [fix] fix typos (open-mmlab#872) * Fix 3 unworking configs (open-mmlab#882) * [Fix] Fix `index.rst` for Chinese docs (open-mmlab#873) * Fix index.rst for zh docs * Change switch language * [Fix] Centerpoint head nested list transpose (open-mmlab#879) * FIX Transpose nested lists without Numpy * Removed unused Numpy import * [Enhance] Update PointFusion (open-mmlab#791) * update point fusion * remove LIDAR hardcode * move get_proj_mat_by_coord_type to utils * fix lint * remove todo * fix lint * [Doc] Add nuscenes_det.md Chinese version (open-mmlab#854) * add nus chinese doc * add nuScenes Chinese doc * fix typo * fix typo * fix typo * fix typo * fix typo * [Fix] Fix RegNet pretrained weight loading (open-mmlab#889) * Fix regnet pretrained weight loading * Remove unused file * Fix centerpoint tta (open-mmlab#892) * [Enhance] Add benchmark regression script (open-mmlab#808) * Initial commit * [Feature] Support DGCNN (v1.0.0.dev0) (open-mmlab#896) * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * fix typo * fix typo * fix typo * del gf&fa registry (wo reuse pointnet module) * fix typo * add benchmark and add copyright header (for DGCNN only) * fix typo * fix typo * fix typo * fix typo * fix typo * support dgcnn * Change cam rot_3d_in_axis (open-mmlab#906) * [Doc] Add coord sys tutorial pic and change links to dev branch (open-mmlab#912) * Modify link branch and add pic * Fix pic * Update v1.0.0rc0 changelog * Remove v1.0.0.rc0 changelog * Init v1.0.0.rc0 changelog * Fix minor typos in the zh-CN index.rst * Add master updates in changelog v1.0.0 * Update changelog_v1.0.md * Update changelog_v1.0.md * Update changelog_v1.0.md * Adjust the order of logs * Update the number of developers * Add v1.0.0.rc0 changelog * Delete changelog_v1.0.md * Add RoIPointPool3d back * Change openmmlab pre-commit hook rev * Add links for compatibility doc * Refine details * Update README.md * Update highlights * Update README_zh-CN.md * Update getting_started.md * Update getting_started.md * Update version.py * Fix the released version name * Fix version name * Update version name * Update version name * Update version name * Update version name Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: Xi Liu <75658786+xiliu8006@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> Co-authored-by: Wenhao Wu <79644370+wHao-Wu@users.noreply.github.com> Co-authored-by: dingchang <hudingchang.vendor@sensetime.com> Co-authored-by: 谢恩泽 <Johnny_ez@163.com> Co-authored-by: Robin Karlsson <34254153+robin-karlsson0@users.noreply.github.com> Co-authored-by: Danila Rukhovich <danrukh@gmail.com> Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> Co-authored-by: Wenhao Wu <79644370+wHao-Wu@users.noreply.github.com> Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> Co-authored-by: Tai-Wang <tab_wang@outlook.com> Co-authored-by: Double-Z <zengzeyu@hotmail.com> Co-authored-by: zeyuzeng <zeyuzeng@autox.ai> Co-authored-by: zeyu-hello <zeyuzeng@hotmail.com> Co-authored-by: maskjp <maskjp@163.com> Co-authored-by: peng <maskjp@tamu.edu> Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: Xi Liu <75658786+xiliu8006@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> Co-authored-by: dingchang <hudingchang.vendor@sensetime.com> Co-authored-by: 谢恩泽 <Johnny_ez@163.com> Co-authored-by: Robin Karlsson <34254153+robin-karlsson0@users.noreply.github.com>
filaPro
added a commit
to filaPro/mmdetection3d
that referenced
this pull request
Feb 23, 2022
* Bump to v0.18.0 (open-mmlab#1148) * Update README & getting_started & changelog & version.py * resolve comments * Update the required maximum version of mmcv-full * Update changelog.md * Update getting_started.md * Add highlight in changelog.md * update imvoxelnet citation (open-mmlab#1153) * deprecate the support for "python setup.py test" (open-mmlab#1164) * add OpenMMLab website and platform links (open-mmlab#1176) * [Fix] Update regnet metafile (open-mmlab#1184) * update regnet metafile * Add Architechture in RegNet metafile * fix axis=0 rotation in master branch (open-mmlab#1182) * [Enhance] support semantic seg in Flip3D augmentation (open-mmlab#1181) * support semantic seg in flip * change box_dtype_3d to bbox3d_fields * add point cloud annotation in doc (open-mmlab#1185) * [Fix] Fix bug in non-distributed multi-gpu training/testing (open-mmlab#1197) * Fix bug in non-distributed multi-gpu training/testing * add deprecated warning to void BC-breaking * Add missing explanation of cam_intrinsic in the nuScenes dataset doc (open-mmlab#1193) * [Fix] Fix corner bug in different coordinates (open-mmlab#1212) * fix corner bug in cam coord * fix corner bugs in depth & lidar coord * Bump to v0.18.1 (open-mmlab#1218) * bump to v0.18.1 * fix comments * update bazel version (open-mmlab#1223) * [Fix] fix pointpillars bug on kitti in master branch (open-mmlab#1163) * fix pointpillars bug on kitti in master branch * replace with AlignedAnchorGenerator * Update the installation of MMCV (open-mmlab#1226) * [Fix] Fix a potential overflow bug when post_max_size is set too large in the circle_nms (open-mmlab#1225) * [Fix] overflow bug * [Fix] typo Co-authored-by: zeyuzeng <zeyuzeng@autox.ai> Co-authored-by: zeyu-hello <zeyuzeng@hotmail.com> * Fix PointRCNN bugs (open-mmlab#1224) * fix bug to allow pointnet to train in fp16 (open-mmlab#1207) * fix bug to allow pointnet to train in fp16 * remove unused import * fix lint * fix lint for gather_points_cuda.cu Co-authored-by: peng <maskjp@tamu.edu> * [Fix] Recheck import sorting (open-mmlab#1242) * fix missed mmcv * reinstall pre-commit and recheck * fix inference_demo.ipynb bug (open-mmlab#1236) * [Enhance] upgrade PointPillars performace on dev branch (open-mmlab#1166) * upgrade PointPillars performace on dev branch * update DynamicPillarFeatureNet * fix comments * change to AlignedAnchor3DRangeGenerator * change to AlignedAnchor3DRangeGenerator * fix * replace with AlignedAnchorGenerator * fix lint * update using isort * Bump to v1.0.0.rc0 (open-mmlab#928) * [Refactor] Main code modification for coordinate system refactor (open-mmlab#677) * [Enhance] Add script for data update (open-mmlab#774) * Fixed wrong config paths and fixed a bug in test * Fixed metafile * Coord sys refactor (main code) * Update test_waymo_dataset.py * Manually resolve conflict * Removed unused lines and fixed imports * remove coord2box and box2coord * update dir_limit_offset * Some minor improvements * Removed some \s in comments * Revert a change * Change Box3DMode to Coord3DMode where points are converted * Fix points_in_bbox function * Fix Imvoxelnet config * Revert adding a line * Fix rotation bug when batch size is 0 * Keep sign of dir_scores as before * Fix several comments * Add a comment * Fix docstring * Add data update scripts * Fix comments * fix import (open-mmlab#839) * [Enhance] refactor iou_neg_piecewise_sampler.py (open-mmlab#842) * [Refactor] Main code modification for coordinate system refactor (open-mmlab#677) * [Enhance] Add script for data update (open-mmlab#774) * Fixed wrong config paths and fixed a bug in test * Fixed metafile * Coord sys refactor (main code) * Update test_waymo_dataset.py * Manually resolve conflict * Removed unused lines and fixed imports * remove coord2box and box2coord * update dir_limit_offset * Some minor improvements * Removed some \s in comments * Revert a change * Change Box3DMode to Coord3DMode where points are converted * Fix points_in_bbox function * Fix Imvoxelnet config * Revert adding a line * Fix rotation bug when batch size is 0 * Keep sign of dir_scores as before * Fix several comments * Add a comment * Fix docstring * Add data update scripts * Fix comments * fix import * refactor iou_neg_piecewise_sampler.py * add docstring * modify docstring Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> * [Feature] Add roipooling cuda ops (open-mmlab#843) * [Refactor] Main code modification for coordinate system refactor (open-mmlab#677) * [Enhance] Add script for data update (open-mmlab#774) * Fixed wrong config paths and fixed a bug in test * Fixed metafile * Coord sys refactor (main code) * Update test_waymo_dataset.py * Manually resolve conflict * Removed unused lines and fixed imports * remove coord2box and box2coord * update dir_limit_offset * Some minor improvements * Removed some \s in comments * Revert a change * Change Box3DMode to Coord3DMode where points are converted * Fix points_in_bbox function * Fix Imvoxelnet config * Revert adding a line * Fix rotation bug when batch size is 0 * Keep sign of dir_scores as before * Fix several comments * Add a comment * Fix docstring * Add data update scripts * Fix comments * fix import * add roipooling cuda ops * add roi extractor * add test_roi_extractor unittest * Modify setup.py to install roipooling ops * modify docstring * remove enlarge bbox in roipoint pooling * add_roipooling_ops * modify docstring Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> * [Refactor] Refactor code structure and docstrings (open-mmlab#803) * refactor points_in_boxes * Merge same functions of three boxes * More docstring fixes and unify x/y/z size * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Remove None in function param type * Fix unittest * Add comments for NMS functions * Merge methods of Points * Add unittest * Add optional and default value * Fix box conversion and add unittest * Fix comments * Add unit test * Indent * Fix CI * Remove useless \\ * Remove useless \\ * Remove useless \\ * Remove useless \\ * Remove useless \\ * Add unit test for box bev * More unit tests and refine docstrings in box_np_ops * Fix comment * Add deprecation warning * [Feature] PointXYZWHLRBBoxCoder (open-mmlab#856) * support PointBasedBoxCoder * fix unittest bug * support unittest in gpu * support unittest in gpu * modified docstring * add args * add args * [Enhance] Change Groupfree3D config (open-mmlab#855) * All mods * PointSample * PointSample * [Doc] Add tutorials/data_pipeline Chinese version (open-mmlab#827) * [Doc] Add tutorials/data_pipeline Chinese version * refine doc * Use the absolute link * Use the absolute link Co-authored-by: Tai-Wang <tab_wang@outlook.com> * [Doc] Add Chinese doc for `scannet_det.md` (open-mmlab#836) * Part * Complete * Fix comments * Fix comments * [Doc] Add Chinese doc for `waymo_det.md` (open-mmlab#859) * Add complete translation * Refinements * Fix comments * Fix a minor typo Co-authored-by: Tai-Wang <tab_wang@outlook.com> * Remove 2D annotations on Lyft (open-mmlab#867) * Add header for files (open-mmlab#869) * Add header for files * Add header for files * Add header for files * Add header for files * [fix] fix typos (open-mmlab#872) * Fix 3 unworking configs (open-mmlab#882) * [Fix] Fix `index.rst` for Chinese docs (open-mmlab#873) * Fix index.rst for zh docs * Change switch language * [Fix] Centerpoint head nested list transpose (open-mmlab#879) * FIX Transpose nested lists without Numpy * Removed unused Numpy import * [Enhance] Update PointFusion (open-mmlab#791) * update point fusion * remove LIDAR hardcode * move get_proj_mat_by_coord_type to utils * fix lint * remove todo * fix lint * [Doc] Add nuscenes_det.md Chinese version (open-mmlab#854) * add nus chinese doc * add nuScenes Chinese doc * fix typo * fix typo * fix typo * fix typo * fix typo * [Fix] Fix RegNet pretrained weight loading (open-mmlab#889) * Fix regnet pretrained weight loading * Remove unused file * Fix centerpoint tta (open-mmlab#892) * [Enhance] Add benchmark regression script (open-mmlab#808) * Initial commit * [Feature] Support DGCNN (v1.0.0.dev0) (open-mmlab#896) * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * fix typo * fix typo * fix typo * del gf&fa registry (wo reuse pointnet module) * fix typo * add benchmark and add copyright header (for DGCNN only) * fix typo * fix typo * fix typo * fix typo * fix typo * support dgcnn * Change cam rot_3d_in_axis (open-mmlab#906) * [Doc] Add coord sys tutorial pic and change links to dev branch (open-mmlab#912) * Modify link branch and add pic * Fix pic * Update v1.0.0rc0 changelog * Remove v1.0.0.rc0 changelog * Init v1.0.0.rc0 changelog * Fix minor typos in the zh-CN index.rst * Add master updates in changelog v1.0.0 * Update changelog_v1.0.md * Update changelog_v1.0.md * Update changelog_v1.0.md * Adjust the order of logs * Update the number of developers * Add v1.0.0.rc0 changelog * Delete changelog_v1.0.md * Add RoIPointPool3d back * Change openmmlab pre-commit hook rev * Add links for compatibility doc * Refine details * Update README.md * Update highlights * Update README_zh-CN.md * Update getting_started.md * Update getting_started.md * Update version.py * Fix the released version name * Fix version name * Update version name * Update version name * Update version name * Update version name Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: Xi Liu <75658786+xiliu8006@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> Co-authored-by: Wenhao Wu <79644370+wHao-Wu@users.noreply.github.com> Co-authored-by: dingchang <hudingchang.vendor@sensetime.com> Co-authored-by: 谢恩泽 <Johnny_ez@163.com> Co-authored-by: Robin Karlsson <34254153+robin-karlsson0@users.noreply.github.com> Co-authored-by: Danila Rukhovich <danrukh@gmail.com> Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> * fix ci in dev branch (open-mmlab#1264) Co-authored-by: Wenhao Wu <79644370+wHao-Wu@users.noreply.github.com> Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> Co-authored-by: Tai-Wang <tab_wang@outlook.com> Co-authored-by: Double-Z <zengzeyu@hotmail.com> Co-authored-by: zeyuzeng <zeyuzeng@autox.ai> Co-authored-by: zeyu-hello <zeyuzeng@hotmail.com> Co-authored-by: maskjp <maskjp@163.com> Co-authored-by: peng <maskjp@tamu.edu> Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: Xi Liu <75658786+xiliu8006@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> Co-authored-by: dingchang <hudingchang.vendor@sensetime.com> Co-authored-by: 谢恩泽 <Johnny_ez@163.com> Co-authored-by: Robin Karlsson <34254153+robin-karlsson0@users.noreply.github.com>
ZwwWayne
pushed a commit
that referenced
this pull request
Mar 9, 2022
* add scannet instance dataset with metrics * fix import * add missing import * fix comments and docstrings * merge v1.0.0.dev0 to scannet_instance_dataset (#1) * Bump to v0.18.0 (#1148) * Update README & getting_started & changelog & version.py * resolve comments * Update the required maximum version of mmcv-full * Update changelog.md * Update getting_started.md * Add highlight in changelog.md * update imvoxelnet citation (#1153) * deprecate the support for "python setup.py test" (#1164) * add OpenMMLab website and platform links (#1176) * [Fix] Update regnet metafile (#1184) * update regnet metafile * Add Architechture in RegNet metafile * fix axis=0 rotation in master branch (#1182) * [Enhance] support semantic seg in Flip3D augmentation (#1181) * support semantic seg in flip * change box_dtype_3d to bbox3d_fields * add point cloud annotation in doc (#1185) * [Fix] Fix bug in non-distributed multi-gpu training/testing (#1197) * Fix bug in non-distributed multi-gpu training/testing * add deprecated warning to void BC-breaking * Add missing explanation of cam_intrinsic in the nuScenes dataset doc (#1193) * [Fix] Fix corner bug in different coordinates (#1212) * fix corner bug in cam coord * fix corner bugs in depth & lidar coord * Bump to v0.18.1 (#1218) * bump to v0.18.1 * fix comments * update bazel version (#1223) * [Fix] fix pointpillars bug on kitti in master branch (#1163) * fix pointpillars bug on kitti in master branch * replace with AlignedAnchorGenerator * Update the installation of MMCV (#1226) * [Fix] Fix a potential overflow bug when post_max_size is set too large in the circle_nms (#1225) * [Fix] overflow bug * [Fix] typo Co-authored-by: zeyuzeng <zeyuzeng@autox.ai> Co-authored-by: zeyu-hello <zeyuzeng@hotmail.com> * Fix PointRCNN bugs (#1224) * fix bug to allow pointnet to train in fp16 (#1207) * fix bug to allow pointnet to train in fp16 * remove unused import * fix lint * fix lint for gather_points_cuda.cu Co-authored-by: peng <maskjp@tamu.edu> * [Fix] Recheck import sorting (#1242) * fix missed mmcv * reinstall pre-commit and recheck * fix inference_demo.ipynb bug (#1236) * [Enhance] upgrade PointPillars performace on dev branch (#1166) * upgrade PointPillars performace on dev branch * update DynamicPillarFeatureNet * fix comments * change to AlignedAnchor3DRangeGenerator * change to AlignedAnchor3DRangeGenerator * fix * replace with AlignedAnchorGenerator * fix lint * update using isort * Bump to v1.0.0.rc0 (#928) * [Refactor] Main code modification for coordinate system refactor (#677) * [Enhance] Add script for data update (#774) * Fixed wrong config paths and fixed a bug in test * Fixed metafile * Coord sys refactor (main code) * Update test_waymo_dataset.py * Manually resolve conflict * Removed unused lines and fixed imports * remove coord2box and box2coord * update dir_limit_offset * Some minor improvements * Removed some \s in comments * Revert a change * Change Box3DMode to Coord3DMode where points are converted * Fix points_in_bbox function * Fix Imvoxelnet config * Revert adding a line * Fix rotation bug when batch size is 0 * Keep sign of dir_scores as before * Fix several comments * Add a comment * Fix docstring * Add data update scripts * Fix comments * fix import (#839) * [Enhance] refactor iou_neg_piecewise_sampler.py (#842) * [Refactor] Main code modification for coordinate system refactor (#677) * [Enhance] Add script for data update (#774) * Fixed wrong config paths and fixed a bug in test * Fixed metafile * Coord sys refactor (main code) * Update test_waymo_dataset.py * Manually resolve conflict * Removed unused lines and fixed imports * remove coord2box and box2coord * update dir_limit_offset * Some minor improvements * Removed some \s in comments * Revert a change * Change Box3DMode to Coord3DMode where points are converted * Fix points_in_bbox function * Fix Imvoxelnet config * Revert adding a line * Fix rotation bug when batch size is 0 * Keep sign of dir_scores as before * Fix several comments * Add a comment * Fix docstring * Add data update scripts * Fix comments * fix import * refactor iou_neg_piecewise_sampler.py * add docstring * modify docstring Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> * [Feature] Add roipooling cuda ops (#843) * [Refactor] Main code modification for coordinate system refactor (#677) * [Enhance] Add script for data update (#774) * Fixed wrong config paths and fixed a bug in test * Fixed metafile * Coord sys refactor (main code) * Update test_waymo_dataset.py * Manually resolve conflict * Removed unused lines and fixed imports * remove coord2box and box2coord * update dir_limit_offset * Some minor improvements * Removed some \s in comments * Revert a change * Change Box3DMode to Coord3DMode where points are converted * Fix points_in_bbox function * Fix Imvoxelnet config * Revert adding a line * Fix rotation bug when batch size is 0 * Keep sign of dir_scores as before * Fix several comments * Add a comment * Fix docstring * Add data update scripts * Fix comments * fix import * add roipooling cuda ops * add roi extractor * add test_roi_extractor unittest * Modify setup.py to install roipooling ops * modify docstring * remove enlarge bbox in roipoint pooling * add_roipooling_ops * modify docstring Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> * [Refactor] Refactor code structure and docstrings (#803) * refactor points_in_boxes * Merge same functions of three boxes * More docstring fixes and unify x/y/z size * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Remove None in function param type * Fix unittest * Add comments for NMS functions * Merge methods of Points * Add unittest * Add optional and default value * Fix box conversion and add unittest * Fix comments * Add unit test * Indent * Fix CI * Remove useless \\ * Remove useless \\ * Remove useless \\ * Remove useless \\ * Remove useless \\ * Add unit test for box bev * More unit tests and refine docstrings in box_np_ops * Fix comment * Add deprecation warning * [Feature] PointXYZWHLRBBoxCoder (#856) * support PointBasedBoxCoder * fix unittest bug * support unittest in gpu * support unittest in gpu * modified docstring * add args * add args * [Enhance] Change Groupfree3D config (#855) * All mods * PointSample * PointSample * [Doc] Add tutorials/data_pipeline Chinese version (#827) * [Doc] Add tutorials/data_pipeline Chinese version * refine doc * Use the absolute link * Use the absolute link Co-authored-by: Tai-Wang <tab_wang@outlook.com> * [Doc] Add Chinese doc for `scannet_det.md` (#836) * Part * Complete * Fix comments * Fix comments * [Doc] Add Chinese doc for `waymo_det.md` (#859) * Add complete translation * Refinements * Fix comments * Fix a minor typo Co-authored-by: Tai-Wang <tab_wang@outlook.com> * Remove 2D annotations on Lyft (#867) * Add header for files (#869) * Add header for files * Add header for files * Add header for files * Add header for files * [fix] fix typos (#872) * Fix 3 unworking configs (#882) * [Fix] Fix `index.rst` for Chinese docs (#873) * Fix index.rst for zh docs * Change switch language * [Fix] Centerpoint head nested list transpose (#879) * FIX Transpose nested lists without Numpy * Removed unused Numpy import * [Enhance] Update PointFusion (#791) * update point fusion * remove LIDAR hardcode * move get_proj_mat_by_coord_type to utils * fix lint * remove todo * fix lint * [Doc] Add nuscenes_det.md Chinese version (#854) * add nus chinese doc * add nuScenes Chinese doc * fix typo * fix typo * fix typo * fix typo * fix typo * [Fix] Fix RegNet pretrained weight loading (#889) * Fix regnet pretrained weight loading * Remove unused file * Fix centerpoint tta (#892) * [Enhance] Add benchmark regression script (#808) * Initial commit * [Feature] Support DGCNN (v1.0.0.dev0) (#896) * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * fix typo * fix typo * fix typo * del gf&fa registry (wo reuse pointnet module) * fix typo * add benchmark and add copyright header (for DGCNN only) * fix typo * fix typo * fix typo * fix typo * fix typo * support dgcnn * Change cam rot_3d_in_axis (#906) * [Doc] Add coord sys tutorial pic and change links to dev branch (#912) * Modify link branch and add pic * Fix pic * Update v1.0.0rc0 changelog * Remove v1.0.0.rc0 changelog * Init v1.0.0.rc0 changelog * Fix minor typos in the zh-CN index.rst * Add master updates in changelog v1.0.0 * Update changelog_v1.0.md * Update changelog_v1.0.md * Update changelog_v1.0.md * Adjust the order of logs * Update the number of developers * Add v1.0.0.rc0 changelog * Delete changelog_v1.0.md * Add RoIPointPool3d back * Change openmmlab pre-commit hook rev * Add links for compatibility doc * Refine details * Update README.md * Update highlights * Update README_zh-CN.md * Update getting_started.md * Update getting_started.md * Update version.py * Fix the released version name * Fix version name * Update version name * Update version name * Update version name * Update version name Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: Xi Liu <75658786+xiliu8006@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> Co-authored-by: Wenhao Wu <79644370+wHao-Wu@users.noreply.github.com> Co-authored-by: dingchang <hudingchang.vendor@sensetime.com> Co-authored-by: 谢恩泽 <Johnny_ez@163.com> Co-authored-by: Robin Karlsson <34254153+robin-karlsson0@users.noreply.github.com> Co-authored-by: Danila Rukhovich <danrukh@gmail.com> Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> Co-authored-by: Wenhao Wu <79644370+wHao-Wu@users.noreply.github.com> Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> Co-authored-by: Tai-Wang <tab_wang@outlook.com> Co-authored-by: Double-Z <zengzeyu@hotmail.com> Co-authored-by: zeyuzeng <zeyuzeng@autox.ai> Co-authored-by: zeyu-hello <zeyuzeng@hotmail.com> Co-authored-by: maskjp <maskjp@163.com> Co-authored-by: peng <maskjp@tamu.edu> Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: Xi Liu <75658786+xiliu8006@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> Co-authored-by: dingchang <hudingchang.vendor@sensetime.com> Co-authored-by: 谢恩泽 <Johnny_ez@163.com> Co-authored-by: Robin Karlsson <34254153+robin-karlsson0@users.noreply.github.com> * fix lint, add docstring * V1.0.0.dev0 (#2) * Bump to v0.18.0 (#1148) * Update README & getting_started & changelog & version.py * resolve comments * Update the required maximum version of mmcv-full * Update changelog.md * Update getting_started.md * Add highlight in changelog.md * update imvoxelnet citation (#1153) * deprecate the support for "python setup.py test" (#1164) * add OpenMMLab website and platform links (#1176) * [Fix] Update regnet metafile (#1184) * update regnet metafile * Add Architechture in RegNet metafile * fix axis=0 rotation in master branch (#1182) * [Enhance] support semantic seg in Flip3D augmentation (#1181) * support semantic seg in flip * change box_dtype_3d to bbox3d_fields * add point cloud annotation in doc (#1185) * [Fix] Fix bug in non-distributed multi-gpu training/testing (#1197) * Fix bug in non-distributed multi-gpu training/testing * add deprecated warning to void BC-breaking * Add missing explanation of cam_intrinsic in the nuScenes dataset doc (#1193) * [Fix] Fix corner bug in different coordinates (#1212) * fix corner bug in cam coord * fix corner bugs in depth & lidar coord * Bump to v0.18.1 (#1218) * bump to v0.18.1 * fix comments * update bazel version (#1223) * [Fix] fix pointpillars bug on kitti in master branch (#1163) * fix pointpillars bug on kitti in master branch * replace with AlignedAnchorGenerator * Update the installation of MMCV (#1226) * [Fix] Fix a potential overflow bug when post_max_size is set too large in the circle_nms (#1225) * [Fix] overflow bug * [Fix] typo Co-authored-by: zeyuzeng <zeyuzeng@autox.ai> Co-authored-by: zeyu-hello <zeyuzeng@hotmail.com> * Fix PointRCNN bugs (#1224) * fix bug to allow pointnet to train in fp16 (#1207) * fix bug to allow pointnet to train in fp16 * remove unused import * fix lint * fix lint for gather_points_cuda.cu Co-authored-by: peng <maskjp@tamu.edu> * [Fix] Recheck import sorting (#1242) * fix missed mmcv * reinstall pre-commit and recheck * fix inference_demo.ipynb bug (#1236) * [Enhance] upgrade PointPillars performace on dev branch (#1166) * upgrade PointPillars performace on dev branch * update DynamicPillarFeatureNet * fix comments * change to AlignedAnchor3DRangeGenerator * change to AlignedAnchor3DRangeGenerator * fix * replace with AlignedAnchorGenerator * fix lint * update using isort * Bump to v1.0.0.rc0 (#928) * [Refactor] Main code modification for coordinate system refactor (#677) * [Enhance] Add script for data update (#774) * Fixed wrong config paths and fixed a bug in test * Fixed metafile * Coord sys refactor (main code) * Update test_waymo_dataset.py * Manually resolve conflict * Removed unused lines and fixed imports * remove coord2box and box2coord * update dir_limit_offset * Some minor improvements * Removed some \s in comments * Revert a change * Change Box3DMode to Coord3DMode where points are converted * Fix points_in_bbox function * Fix Imvoxelnet config * Revert adding a line * Fix rotation bug when batch size is 0 * Keep sign of dir_scores as before * Fix several comments * Add a comment * Fix docstring * Add data update scripts * Fix comments * fix import (#839) * [Enhance] refactor iou_neg_piecewise_sampler.py (#842) * [Refactor] Main code modification for coordinate system refactor (#677) * [Enhance] Add script for data update (#774) * Fixed wrong config paths and fixed a bug in test * Fixed metafile * Coord sys refactor (main code) * Update test_waymo_dataset.py * Manually resolve conflict * Removed unused lines and fixed imports * remove coord2box and box2coord * update dir_limit_offset * Some minor improvements * Removed some \s in comments * Revert a change * Change Box3DMode to Coord3DMode where points are converted * Fix points_in_bbox function * Fix Imvoxelnet config * Revert adding a line * Fix rotation bug when batch size is 0 * Keep sign of dir_scores as before * Fix several comments * Add a comment * Fix docstring * Add data update scripts * Fix comments * fix import * refactor iou_neg_piecewise_sampler.py * add docstring * modify docstring Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> * [Feature] Add roipooling cuda ops (#843) * [Refactor] Main code modification for coordinate system refactor (#677) * [Enhance] Add script for data update (#774) * Fixed wrong config paths and fixed a bug in test * Fixed metafile * Coord sys refactor (main code) * Update test_waymo_dataset.py * Manually resolve conflict * Removed unused lines and fixed imports * remove coord2box and box2coord * update dir_limit_offset * Some minor improvements * Removed some \s in comments * Revert a change * Change Box3DMode to Coord3DMode where points are converted * Fix points_in_bbox function * Fix Imvoxelnet config * Revert adding a line * Fix rotation bug when batch size is 0 * Keep sign of dir_scores as before * Fix several comments * Add a comment * Fix docstring * Add data update scripts * Fix comments * fix import * add roipooling cuda ops * add roi extractor * add test_roi_extractor unittest * Modify setup.py to install roipooling ops * modify docstring * remove enlarge bbox in roipoint pooling * add_roipooling_ops * modify docstring Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> * [Refactor] Refactor code structure and docstrings (#803) * refactor points_in_boxes * Merge same functions of three boxes * More docstring fixes and unify x/y/z size * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Add "optional" and fix "Default" * Remove None in function param type * Fix unittest * Add comments for NMS functions * Merge methods of Points * Add unittest * Add optional and default value * Fix box conversion and add unittest * Fix comments * Add unit test * Indent * Fix CI * Remove useless \\ * Remove useless \\ * Remove useless \\ * Remove useless \\ * Remove useless \\ * Add unit test for box bev * More unit tests and refine docstrings in box_np_ops * Fix comment * Add deprecation warning * [Feature] PointXYZWHLRBBoxCoder (#856) * support PointBasedBoxCoder * fix unittest bug * support unittest in gpu * support unittest in gpu * modified docstring * add args * add args * [Enhance] Change Groupfree3D config (#855) * All mods * PointSample * PointSample * [Doc] Add tutorials/data_pipeline Chinese version (#827) * [Doc] Add tutorials/data_pipeline Chinese version * refine doc * Use the absolute link * Use the absolute link Co-authored-by: Tai-Wang <tab_wang@outlook.com> * [Doc] Add Chinese doc for `scannet_det.md` (#836) * Part * Complete * Fix comments * Fix comments * [Doc] Add Chinese doc for `waymo_det.md` (#859) * Add complete translation * Refinements * Fix comments * Fix a minor typo Co-authored-by: Tai-Wang <tab_wang@outlook.com> * Remove 2D annotations on Lyft (#867) * Add header for files (#869) * Add header for files * Add header for files * Add header for files * Add header for files * [fix] fix typos (#872) * Fix 3 unworking configs (#882) * [Fix] Fix `index.rst` for Chinese docs (#873) * Fix index.rst for zh docs * Change switch language * [Fix] Centerpoint head nested list transpose (#879) * FIX Transpose nested lists without Numpy * Removed unused Numpy import * [Enhance] Update PointFusion (#791) * update point fusion * remove LIDAR hardcode * move get_proj_mat_by_coord_type to utils * fix lint * remove todo * fix lint * [Doc] Add nuscenes_det.md Chinese version (#854) * add nus chinese doc * add nuScenes Chinese doc * fix typo * fix typo * fix typo * fix typo * fix typo * [Fix] Fix RegNet pretrained weight loading (#889) * Fix regnet pretrained weight loading * Remove unused file * Fix centerpoint tta (#892) * [Enhance] Add benchmark regression script (#808) * Initial commit * [Feature] Support DGCNN (v1.0.0.dev0) (#896) * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * support dgcnn * fix typo * fix typo * fix typo * del gf&fa registry (wo reuse pointnet module) * fix typo * add benchmark and add copyright header (for DGCNN only) * fix typo * fix typo * fix typo * fix typo * fix typo * support dgcnn * Change cam rot_3d_in_axis (#906) * [Doc] Add coord sys tutorial pic and change links to dev branch (#912) * Modify link branch and add pic * Fix pic * Update v1.0.0rc0 changelog * Remove v1.0.0.rc0 changelog * Init v1.0.0.rc0 changelog * Fix minor typos in the zh-CN index.rst * Add master updates in changelog v1.0.0 * Update changelog_v1.0.md * Update changelog_v1.0.md * Update changelog_v1.0.md * Adjust the order of logs * Update the number of developers * Add v1.0.0.rc0 changelog * Delete changelog_v1.0.md * Add RoIPointPool3d back * Change openmmlab pre-commit hook rev * Add links for compatibility doc * Refine details * Update README.md * Update highlights * Update README_zh-CN.md * Update getting_started.md * Update getting_started.md * Update version.py * Fix the released version name * Fix version name * Update version name * Update version name * Update version name * Update version name Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: Xi Liu <75658786+xiliu8006@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> Co-authored-by: Wenhao Wu <79644370+wHao-Wu@users.noreply.github.com> Co-authored-by: dingchang <hudingchang.vendor@sensetime.com> Co-authored-by: 谢恩泽 <Johnny_ez@163.com> Co-authored-by: Robin Karlsson <34254153+robin-karlsson0@users.noreply.github.com> Co-authored-by: Danila Rukhovich <danrukh@gmail.com> Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> * fix ci in dev branch (#1264) Co-authored-by: Wenhao Wu <79644370+wHao-Wu@users.noreply.github.com> Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> Co-authored-by: Tai-Wang <tab_wang@outlook.com> Co-authored-by: Double-Z <zengzeyu@hotmail.com> Co-authored-by: zeyuzeng <zeyuzeng@autox.ai> Co-authored-by: zeyu-hello <zeyuzeng@hotmail.com> Co-authored-by: maskjp <maskjp@163.com> Co-authored-by: peng <maskjp@tamu.edu> Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: Xi Liu <75658786+xiliu8006@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> Co-authored-by: dingchang <hudingchang.vendor@sensetime.com> Co-authored-by: 谢恩泽 <Johnny_ez@163.com> Co-authored-by: Robin Karlsson <34254153+robin-karlsson0@users.noreply.github.com> * try revert imports Co-authored-by: Wenhao Wu <79644370+wHao-Wu@users.noreply.github.com> Co-authored-by: ChaimZhu <zhuchenming@pjlab.org.cn> Co-authored-by: Tai-Wang <tab_wang@outlook.com> Co-authored-by: Double-Z <zengzeyu@hotmail.com> Co-authored-by: zeyuzeng <zeyuzeng@autox.ai> Co-authored-by: zeyu-hello <zeyuzeng@hotmail.com> Co-authored-by: maskjp <maskjp@163.com> Co-authored-by: peng <maskjp@tamu.edu> Co-authored-by: Yezhen Cong <52420115+THU17cyz@users.noreply.github.com> Co-authored-by: Xi Liu <75658786+xiliu8006@users.noreply.github.com> Co-authored-by: THU17cyz <congyezhen71@hotmail.com> Co-authored-by: dingchang <hudingchang.vendor@sensetime.com> Co-authored-by: 谢恩泽 <Johnny_ez@163.com> Co-authored-by: Robin Karlsson <34254153+robin-karlsson0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Since MMDP does not support non-distributed multi-GPU training, --gpus in train.py lost its role, so it is removed, --gpu-ids is changed to --gpu-id, because only one GPU can be specified for non-distribution training and testing.
If the number of GPUs is more than 1, there will be an assertion error in MMDP because MMDP does not support the situation with more than one GPU.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist