Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support inference of DSVT in projects #2606

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

JingweiZhang12
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 50.00% and no project coverage change.

Comparison is base (3fa0e8b) 46.91% compared to head (0a11faf) 46.91%.

❗ Current head 0a11faf differs from pull request most recent head ca07272. Consider uploading reports for the commit ca07272 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #2606   +/-   ##
========================================
  Coverage    46.91%   46.91%           
========================================
  Files          277      277           
  Lines        23381    23387    +6     
  Branches      3644     3645    +1     
========================================
+ Hits         10969    10972    +3     
- Misses       11719    11721    +2     
- Partials       693      694    +1     
Flag Coverage Δ
unittests 46.91% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/necks/second_fpn.py 90.62% <ø> (ø)
mmdet3d/datasets/transforms/loading.py 44.97% <50.00%> (+0.05%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor Author

@JingweiZhang12 JingweiZhang12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rechecked.

@JingweiZhang12 JingweiZhang12 merged commit 8fb2cf6 into open-mmlab:dev-1.x Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant