[Refactor] Refactor structure of cylinder3d
#2711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #2711 +/- ##
===========================================
- Coverage 46.70% 46.70% -0.01%
===========================================
Files 277 277
Lines 23635 23654 +19
Branches 3704 3704
===========================================
+ Hits 11039 11047 +8
- Misses 11892 11902 +10
- Partials 704 705 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Xiangxu-0103
force-pushed
the
refactor_cylinder3d
branch
from
45c2846
to
9023bbe
Compare
2 tasks
ZCMax
reviewed
Dec 20, 2023
ZCMax
reviewed
Dec 20, 2023
ZCMax
reviewed
Dec 20, 2023
ZCMax
reviewed
Dec 20, 2023
Tai-Wang
reviewed
Jan 24, 2024
| @@ -135,10 +142,32 @@ def predict(self, | |||
| # 3D segmentation requires per-point prediction, so it's impossible | |||
| # to use down-sampling to get a batch of scenes with same num_points | |||
| # therefore, we only support testing one scene every time | |||
| x = self.extract_feat(batch_inputs_dict) | |||
| seg_logits_list = self.decode_head.predict(x, batch_inputs_dict, | |||
| voxel_dict = self.extract_feat(batch_inputs_dict) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist