Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support DSVT training #2738

Merged
merged 28 commits into from
Dec 28, 2023
Merged

Conversation

sunjiahao1999
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ sunjiahao1999
✅ JingweiZhang12
❌ sjh


sjh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b88c7b) 47.24% compared to head (fc93172) 47.24%.

❗ Current head fc93172 differs from pull request most recent head 7bbaeb7. Consider uploading reports for the commit 7bbaeb7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #2738   +/-   ##
========================================
  Coverage    47.24%   47.24%           
========================================
  Files          277      277           
  Lines        23417    23416    -1     
  Branches      3658     3657    -1     
========================================
  Hits         11063    11063           
  Misses       11640    11640           
+ Partials       714      713    -1     
Flag Coverage Δ
unittests 47.24% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mmdet3d/models/necks/second_fpn.py Show resolved Hide resolved
@@ -275,12 +275,13 @@ def in_range_3d(
Tensor: A binary vector indicating whether each point is inside the
reference range.
"""
in_range_flags = ((self.tensor[:, 0] > box_range[0])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bbox3d.in_range_3d should filter out bboxes where the gravity center of the bbox is not in the target range, not the bottom center. Btw, this function not use the training/testing pipeline of any other model, except for DSVT. Therefore, this modification does not cause BC-breaking.

@@ -21,6 +21,12 @@ def parse_args():
action='store_true',
default=False,
help='enable automatic-mixed-precision training')
parser.add_argument(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add --sync_bn option in training.

projects/DSVT/README.md Outdated Show resolved Hide resolved
projects/DSVT/dsvt/utils.py Outdated Show resolved Hide resolved
projects/DSVT/README.md Outdated Show resolved Hide resolved
@Tai-Wang Tai-Wang merged commit 762e3b5 into open-mmlab:dev-1.x Dec 28, 2023
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants