[Enhance] Refactor init_weight #378

xiliu8006 · 2021-03-24T04:18:49Z

Motivation

Refactoring model initialization methods based MMCV. For more information, please refer to open-mmlab/mmcv#780

Dependency

Training results

Methods	config	Before refactor init_weight()	After after init_weight()
3DSSD	config	78.39(mAP)	78.30(mAP)
VoteNet	config	59.07(AP@0.25), 35.77(AP@0.5)	60.01(AP@0.25), 36.77(AP@0.5)
PointPillars-car	config	77.1(mAP)	77.12(mAP)
PartA2	config	79.16(mAP)	79.47(mAP)
SECOND	config	79.07(mAP)	78.73(mAP)
imVoteNet	config	64.04(AP@0.25)	63.82 (AP@0.25)
CenterPoint	config	56.19(mAP), 64.43(NDS)	0.5627(mAP), 0.6459(NDS)
MVX-Net	config	63.0(mAP)	62.50(mAP)
Regnet	config	41.2(mAP), 55.2(NDS)	41.4(mAP), 54.3(NDS), batch_size=1
H3dnet	config	66.43(AP@0.25), 48.01(AP@0.5)	65.76(AP@0.25), 47.32(AP@0.5)
SSN	config	41.56(mAP), 54.83(NDS)	39.38(mAP), 54.01(NDS)

CLAassistant · 2021-04-07T02:50:26Z

All committers have signed the CLA.

mmdet3d/models/detectors/voxelnet.py

codecov · 2021-05-05T07:49:34Z

Codecov Report

Merging #378 (87b04f6) into master (cde515d) will decrease coverage by 1.73%.
The diff coverage is 71.77%.

❗ Current head 87b04f6 differs from pull request most recent head 8830d63. Consider uploading reports for the commit 8830d63 to get more accurate results

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   50.97%   49.24%   -1.74%     
==========================================
  Files         197      189       -8     
  Lines       15057    14415     -642     
  Branches     2445     2355      -90     
==========================================
- Hits         7675     7098     -577     
+ Misses       6878     6851      -27     
+ Partials      504      466      -38

Flag	Coverage Δ
unittests	`49.24% <71.77%> (-1.74%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmdet3d/apis/inference.py	`38.09% <0.00%> (-15.53%)`	⬇️
mmdet3d/models/dense_heads/parta2_rpn_head.py	`15.84% <ø> (ø)`
mmdet3d/models/dense_heads/ssd_3d_head.py	`13.93% <ø> (-0.36%)`	⬇️
mmdet3d/models/detectors/centerpoint.py	`15.66% <ø> (ø)`
mmdet3d/models/detectors/dynamic_voxelnet.py	`38.70% <ø> (ø)`
mmdet3d/models/detectors/h3dnet.py	`18.18% <ø> (ø)`
mmdet3d/models/detectors/parta2.py	`25.75% <ø> (ø)`
mmdet3d/models/detectors/ssd3dnet.py	`100.00% <ø> (ø)`
mmdet3d/models/detectors/votenet.py	`33.33% <ø> (ø)`
mmdet3d/models/detectors/voxelnet.py	`33.87% <ø> (-41.94%)`	⬇️
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c33d4ec...8830d63. Read the comment docs.

Wuziyi616

I didn't check the model code very carefully.

Wuziyi616 · 2021-05-06T03:01:45Z

docs/getting_started.md

-| 0.7.0               | mmdet>=2.5.0, <=2.11.0 | mmcv-full>=1.1.5, <=1.4|
-| 0.6.0               | mmdet>=2.4.0, <=2.11.0 | mmcv-full>=1.1.3, <=1.2|
-| 0.5.0               | 2.3.0                  | mmcv-full==1.0.5|
+| master              | mmdet>=2.10.0       | mmcv-full>=1.3.2, <=1.4|


Need to change min version of mmdet to 2.12.0 because some of our detectors are inherited from mmdet?

Wuziyi616 · 2021-05-06T03:02:18Z

mmdet3d/__init__.py

@@ -27,7 +27,7 @@ def digit_version(version_str):
    f'Please install mmcv>={mmcv_minimum_version}, <={mmcv_maximum_version}.'

 mmdet_minimum_version = '2.10.0'


Also change the mmdet min version here to 2.12.0?

tests/test_runtime/test_apis.py

docs/getting_started.md

Wuziyi616

I compare this with mmdet's PR and it seems good to me.

docs/getting_started.md

Wuziyi616 · 2021-05-12T15:19:48Z

mmdet3d/models/backbones/pointnet2_sa_ssg.py

-        super().__init__()
+                     normalize_xyz=True),
+                 init_cfg=None):
+        super().__init__(init_cfg=None)


init_cfg=init_cfg

mmdet3d/models/roi_heads/bbox_heads/parta2_bbox_head.py

ZwwWayne · 2021-05-18T16:01:55Z

Need to resolve conflicts.

ZwwWayne · 2021-05-26T09:11:14Z

This PR relies on open-mmlab/mmsegmentation#567

ZwwWayne · 2021-06-06T11:33:28Z

docs/getting_started.md

@@ -12,7 +12,7 @@ The required versions of MMCV, MMDetection and MMSegmentation for different vers

 | MMDetection3D version | MMDetection version | MMSegmentation version |    MMCV version     |
 |:-------------------:|:-------------------:|:-------------------:|:-------------------:|
-| master              | mmdet>=2.10.0, <=2.11.0| mmseg>=0.13.0 | mmcv-full>=1.3.1, <=1.4|
+| master              | mmdet>=2.12.0          | mmseg>=0.13.0 | mmcv-full>=1.2.4, <=1.4|


should >=1.3.1?

sorry，we should >=1.3.2, because mmdet need mmcv-full version >= 1.3.2

ZwwWayne · 2021-06-06T11:34:07Z

docs/tutorials/customize_models.md

@@ -26,16 +26,13 @@ from ..builder import VOXEL_ENCODERS


 @VOXEL_ENCODERS.register_module()
-class HardVFE(nn.Module):
+class HardVFE(BaseModule):

    def __init__(self, arg1, arg2):


should this init add the argument init_cfg?

ZwwWayne · 2021-06-06T11:34:45Z

mmdet3d/__init__.py

@@ -17,7 +17,7 @@ def digit_version(version_str):
    return digit_version


-mmcv_minimum_version = '1.3.1'
+mmcv_minimum_version = '1.3.2'


just use the newest one because we made BC-breaking anyway.

ZwwWayne · 2021-06-06T11:40:41Z

Need to resolve conflicts and update compatibility doc.

* fix ncnn docs` * update 0216

xiliu8006 force-pushed the add_initializer branch from da832a6 to d52c837 Compare April 7, 2021 03:59

ZwwWayne reviewed Apr 23, 2021

View reviewed changes

mmdet3d/models/detectors/voxelnet.py Outdated Show resolved Hide resolved

Wuziyi616 reviewed May 6, 2021

View reviewed changes

ZwwWayne reviewed May 7, 2021

View reviewed changes

tests/test_runtime/test_apis.py Outdated Show resolved Hide resolved

ZwwWayne reviewed May 7, 2021

View reviewed changes

docs/getting_started.md Outdated Show resolved Hide resolved

This was referenced May 8, 2021

[Feature] Support PointNet++ Segmentor #528

Merged

[Enhance] Add MMSeg requirement in docs & code #535

Merged

Wuziyi616 reviewed May 12, 2021

View reviewed changes

Tai-Wang mentioned this pull request May 29, 2021

Higher numpy version request #597

Closed

ZwwWayne reviewed Jun 6, 2021

View reviewed changes

xiliu8006 closed this Jun 7, 2021

xiliu8006 force-pushed the add_initializer branch from 8830d63 to cde515d Compare June 7, 2021 14:54

ZwwWayne mentioned this pull request Jul 1, 2021

[Refactor]: Unified parameter initialization #622

Merged

7 tasks

AndyYuan96 mentioned this pull request Aug 22, 2022

difference result with different version mmdetection3d #1752

Closed

tpoisonooo pushed a commit to tpoisonooo/mmdetection3d that referenced this pull request Sep 5, 2022

[Docs] fix ncnn docs (open-mmlab#378)

85f1778

* fix ncnn docs` * update 0216

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Enhance] Refactor init_weight #378

[Enhance] Refactor init_weight #378

xiliu8006 commented Mar 24, 2021 •

edited

Loading

CLAassistant commented Apr 7, 2021 •

edited

Loading

codecov bot commented May 5, 2021 •

edited

Loading

Wuziyi616 left a comment

Wuziyi616 May 6, 2021

Wuziyi616 May 6, 2021

Wuziyi616 left a comment

Wuziyi616 May 12, 2021

ZwwWayne commented May 18, 2021

ZwwWayne commented May 26, 2021

ZwwWayne Jun 6, 2021

xiliu8006 Jun 7, 2021

ZwwWayne Jun 6, 2021

ZwwWayne Jun 6, 2021

ZwwWayne commented Jun 6, 2021

		@@ -27,7 +27,7 @@ def digit_version(version_str):
		f'Please install mmcv>={mmcv_minimum_version}, <={mmcv_maximum_version}.'

		mmdet_minimum_version = '2.10.0'

[Enhance] Refactor init_weight #378

[Enhance] Refactor init_weight #378

Conversation

xiliu8006 commented Mar 24, 2021 • edited Loading

Motivation

Dependency

Training results

CLAassistant commented Apr 7, 2021 • edited Loading

codecov bot commented May 5, 2021 • edited Loading

Codecov Report

Wuziyi616 left a comment

Choose a reason for hiding this comment

Wuziyi616 May 6, 2021

Choose a reason for hiding this comment

Wuziyi616 May 6, 2021

Choose a reason for hiding this comment

Wuziyi616 left a comment

Choose a reason for hiding this comment

Wuziyi616 May 12, 2021

Choose a reason for hiding this comment

ZwwWayne commented May 18, 2021

ZwwWayne commented May 26, 2021

ZwwWayne Jun 6, 2021

Choose a reason for hiding this comment

xiliu8006 Jun 7, 2021

Choose a reason for hiding this comment

ZwwWayne Jun 6, 2021

Choose a reason for hiding this comment

ZwwWayne Jun 6, 2021

Choose a reason for hiding this comment

ZwwWayne commented Jun 6, 2021

xiliu8006 commented Mar 24, 2021 •

edited

Loading

CLAassistant commented Apr 7, 2021 •

edited

Loading

codecov bot commented May 5, 2021 •

edited

Loading