-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update audit and controller manager with pod labels #3240
Conversation
@jbruce-nex thanks for the PR! Gatekeeper helm chart is autogenerated and these changes will be clobbered in the next release. Please refer to Contributing to Helm Chart for modifying the Helm chart. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3240 +/- ##
==========================================
- Coverage 54.48% 54.39% -0.10%
==========================================
Files 134 134
Lines 12329 12329
==========================================
- Hits 6718 6706 -12
- Misses 5117 5126 +9
- Partials 494 497 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@sozercan - Thanks for the info, I have updated the PR to reflect the changes you suggested. |
Signed-off-by: James Bruce <james.bruce@ba.com>
Signed-off-by: James Bruce <james.bruce@ba.com>
Signed-off-by: James Bruce <james.bruce@ba.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sozercan @maxsmythe should we include this in 3.15 and cherrypick to 3.14 for a new patch release of 3.14? |
Hi @ritazh - version 3.14.0 is currently broken if |
I'm okay with either direction. |
Hi @ritazh @maxsmythe just wondering any chance to merge this in next release please ? |
@jbruce-nex Feel free to cherrypick this to the release-3.15 and the release-3.14 branches. |
@ritazh thanks for this, unfortunately it doesn't help as our policy is to work with stable releases only. Is there an ETA for when this might make it to release? |
@jbruce-nex The upcoming release 3.16 is targeted for end of April. If you need this fix now, my recommendation would be to cherrypick this to the release-3.15 and the release-3.14 branches so we can cut a patch version for these stable releases. |
@jbruce-nex @cbugneac-nex Gatekeeper v3.14.1 and 3.15.1 are now available with this fix. |
…y-agent#3240) Signed-off-by: James Bruce <james.bruce@ba.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
What this PR does / why we need it:
Release 3.14.0 does not have the right spacing for pod labels on the audit deployment and controller manager deployment. As such it fails if any values are placed in podLabels