-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update audit and controller manager with pod labels (#3240) (cherry pick) #3284
Conversation
Signed-off-by: James Bruce <james.bruce@ba.com> Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> (cherry picked from commit 902a1b4)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-3.14 #3284 +/- ##
================================================
+ Coverage 52.87% 52.91% +0.04%
================================================
Files 134 134
Lines 11959 11959
================================================
+ Hits 6323 6328 +5
+ Misses 5135 5131 -4
+ Partials 501 500 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ritazh Any idea why the linting is failing? This passed for the original PR |
Might have been a flake. Rerunning. |
It looks like there are some lint errors in the untouched code: Lint: pkg/mutation/match/match_test.go#L675 @ritazh Fix or ignore? |
These are all in tests, so not super worried, personally |
I'm okay ignoring this. I'm unclear why the same version of golangci-lint-action https://github.com/open-policy-agent/gatekeeper/blob/release-3.15/.github/workflows/workflow.yaml#L53 isn't complaining about the same code: https://github.com/open-policy-agent/gatekeeper/blob/release-3.15/pkg/cachemanager/cachemanager_test.go#L255 |
Revert which commit? I'm okay merging this as-is. IMO we can call this done unless new commits to main are failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Taking this as LGTM I reverted my commit to update the golangci-lint version used in the github action to reduce noise. |
2f0e94c
into
open-policy-agent:release-3.14
Signed-off-by: James Bruce james.bruce@ba.com
Co-authored-by: Rita Zhang rita.z.zhang@gmail.com
(cherry picked from commit 902a1b4)
What this PR does / why we need it:
Details in #3240