Sphincs+ and Crystalsupdate (no AES) #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baentsch
requested review from
xvzcf,
dstebila,
bhess and
jschanck
as code owners
baentsch
changed the title
This was referenced May 15, 2023
xvzcf
approved these changes
May 15, 2023
xvzcf
pushed a commit
that referenced
this pull request
May 15, 2023
* AVX2 test * AVX2 test * add patch; correct aarch64; correct documentation * enable Keccak for Sphincs even if OpenSSL shall provide SHA3 * properly handle xkcp enablement if only specific algorithms are selected * correct conditional setting * re-enable XKCP for other platforms * Windows support * alternate pqcrystals-AES removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines #1455 and #1458 (reference corrected) into one, saving (also CI) time.
@dstebila if you don't want to adapt the algorithm naming in Sphincs+, feel free to simply merge this PR (into #1420), then re-base #1420 and merge that into "main". #1455 and #1458 (reference corrected) could simply be closed and we could have a v0.8.0 RC. Testing that could be facilitated by triggering to run CI of open-quantum-safe/oqs-provider#158