OID update for Sphincs, Dilithium, Kyber #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstebila
approved these changes
May 12, 2023
There was a problem hiding this comment.
I reviewed the updates in oqs-template and they seem fine; I am assuming the rest is all autogenerated.
If we change the SPHINCS+-SHA256-xxx names as in open-quantum-safe/liboqs#1420 (comment) then this will have to be revisited however.
This was referenced May 15, 2023
feventura
pushed a commit
to EntrustCorporation/oqs-provider
that referenced
this pull request
Mar 16, 2024
Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assigns new (O)IDs for all remaining Sphincs+ algorithms and removes Kyber90s and DilithiumAES variants. This may be merged when open-quantum-safe/liboqs#1420 lands.
Given how many algorithms this removes we can enable some more of the remaining Sphincs algs if we want. Proposals/requests welcome.