Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken circleci job for macOS #305

Merged
merged 1 commit into from
Dec 5, 2023

Commits on Dec 4, 2023

  1. Fix broken circleci job for macOS

    This PR updates the openssl version to be installed for testing macOS builds
    
    The circleci config file currently points to openssl@3.1 to install openssl for macOS. This change was made as
    part of the following [PR](open-quantum-safe@080c3dd),
    where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider.
    So the change was made to specify `openssl@3.1`. OpenSSL v3.2 was released last week and the circleci jobs for
    macOS started failing since `openssl@3.1` is no longer available to install using homebrew. Instead the following
    are the options: `openssl@3` (which points to the current stable version, v3.2), `openssl@3.0` and `openssl@1.1`.
    
    Changes made in this PR include:
    - pointing the openssl version back to `openssl@3` since it now points to the latest 3.2
    - a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest
      version (currently vv0.1.29314), this command does not have the --job flag)
    johnma14 committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    ecd2ba5 View commit details
    Browse the repository at this point in the history