-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken circleci job for macOS #305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conceptually the update looks good (except for the single comment just made). But why are there so many CI tasks failing currently?
LGTM too. |
Actually, pretty unacceptable: The difference is in HQC: It seems like |
@baentsch @thb-sb Thank you for figuring out the failing test issue. I was having a hard time figuring that out. Regarding the doc change in this PR, I can remove that but I found that while working on this and trying to do a local CI build. I have the latest version of CircleCI installed (which is |
Ah, OK. Thanks for the explanation. And more importantly, it also doesn't have the --job option. What about just adding "[" "]" around |
Well, apologies for having you try to do this. This should not have happened to begin with. |
Yes, that makes sense. Will do that. Thanks @baentsch |
No worries, its always good learning. |
8b516f1
to
5af5b58
Compare
5af5b58
to
b4c8bfd
Compare
Please rebase to latest main and CI should turn green. |
This PR updates the openssl version to be installed for testing macOS builds The circleci config file currently points to openssl@3.1 to install openssl for macOS. This change was made as part of the following [PR](open-quantum-safe@080c3dd), where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider. So the change was made to specify `openssl@3.1`. OpenSSL v3.2 was released last week and the circleci jobs for macOS started failing since `openssl@3.1` is no longer available to install using homebrew. Instead the following are the options: `openssl@3` (which points to the current stable version, v3.2), `openssl@3.0` and `openssl@1.1`. Changes made in this PR include: - pointing the openssl version back to `openssl@3` since it now points to the latest 3.2 - a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest version (currently vv0.1.29314), this command does not have the --job flag)
b4c8bfd
to
ecd2ba5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @johnma14 !
This PR updates the openssl version to be installed for testing macOS builds The circleci config file currently points to openssl@3.1 to install openssl for macOS. This change was made as part of the following [PR](080c3dd), where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider. So the change was made to specify `openssl@3.1`. OpenSSL v3.2 was released last week and the circleci jobs for macOS started failing since `openssl@3.1` is no longer available to install using homebrew. Instead the following are the options: `openssl@3` (which points to the current stable version, v3.2), `openssl@3.0` and `openssl@1.1`. Changes made in this PR include: - pointing the openssl version back to `openssl@3` since it now points to the latest 3.2 - a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest version (currently vv0.1.29314), this command does not have the --job flag)
This PR updates the openssl version to be installed for testing macOS builds The circleci config file currently points to openssl@3.1 to install openssl for macOS. This change was made as part of the following [PR](080c3dd), where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider. So the change was made to specify `openssl@3.1`. OpenSSL v3.2 was released last week and the circleci jobs for macOS started failing since `openssl@3.1` is no longer available to install using homebrew. Instead the following are the options: `openssl@3` (which points to the current stable version, v3.2), `openssl@3.0` and `openssl@1.1`. Changes made in this PR include: - pointing the openssl version back to `openssl@3` since it now points to the latest 3.2 - a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest version (currently vv0.1.29314), this command does not have the --job flag)
This PR updates the openssl version to be installed for testing macOS builds The circleci config file currently points to openssl@3.1 to install openssl for macOS. This change was made as part of the following [PR](open-quantum-safe@080c3dd), where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider. So the change was made to specify `openssl@3.1`. OpenSSL v3.2 was released last week and the circleci jobs for macOS started failing since `openssl@3.1` is no longer available to install using homebrew. Instead the following are the options: `openssl@3` (which points to the current stable version, v3.2), `openssl@3.0` and `openssl@1.1`. Changes made in this PR include: - pointing the openssl version back to `openssl@3` since it now points to the latest 3.2 - a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest version (currently vv0.1.29314), this command does not have the --job flag) Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
This PR updates the openssl version to be installed for testing macOS builds The circleci config file currently points to openssl@3.1 to install openssl for macOS. This change was made as part of the following [PR](open-quantum-safe@080c3dd), where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider. So the change was made to specify `openssl@3.1`. OpenSSL v3.2 was released last week and the circleci jobs for macOS started failing since `openssl@3.1` is no longer available to install using homebrew. Instead the following are the options: `openssl@3` (which points to the current stable version, v3.2), `openssl@3.0` and `openssl@1.1`. Changes made in this PR include: - pointing the openssl version back to `openssl@3` since it now points to the latest 3.2 - a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest version (currently vv0.1.29314), this command does not have the --job flag) Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
This PR updates the openssl version to be installed for testing macOS builds The circleci config file currently points to openssl@3.1 to install openssl for macOS. This change was made as part of the following [PR](open-quantum-safe@080c3dd), where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider. So the change was made to specify `openssl@3.1`. OpenSSL v3.2 was released last week and the circleci jobs for macOS started failing since `openssl@3.1` is no longer available to install using homebrew. Instead the following are the options: `openssl@3` (which points to the current stable version, v3.2), `openssl@3.0` and `openssl@1.1`. Changes made in this PR include: - pointing the openssl version back to `openssl@3` since it now points to the latest 3.2 - a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest version (currently vv0.1.29314), this command does not have the --job flag) Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
This PR updates the openssl version to be installed for testing macOS builds The circleci config file currently points to openssl@3.1 to install openssl for macOS. This change was made as part of the following [PR](open-quantum-safe@080c3dd), where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider. So the change was made to specify `openssl@3.1`. OpenSSL v3.2 was released last week and the circleci jobs for macOS started failing since `openssl@3.1` is no longer available to install using homebrew. Instead the following are the options: `openssl@3` (which points to the current stable version, v3.2), `openssl@3.0` and `openssl@1.1`. Changes made in this PR include: - pointing the openssl version back to `openssl@3` since it now points to the latest 3.2 - a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest version (currently vv0.1.29314), this command does not have the --job flag) Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
This PR updates the openssl version to be installed for testing macOS builds The circleci config file currently points to openssl@3.1 to install openssl for macOS. This change was made as part of the following [PR](open-quantum-safe@080c3dd), where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider. So the change was made to specify `openssl@3.1`. OpenSSL v3.2 was released last week and the circleci jobs for macOS started failing since `openssl@3.1` is no longer available to install using homebrew. Instead the following are the options: `openssl@3` (which points to the current stable version, v3.2), `openssl@3.0` and `openssl@1.1`. Changes made in this PR include: - pointing the openssl version back to `openssl@3` since it now points to the latest 3.2 - a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest version (currently vv0.1.29314), this command does not have the --job flag) Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
This PR updates the openssl version to be installed for testing macOS builds The circleci config file currently points to openssl@3.1 to install openssl for macOS. This change was made as part of the following [PR](open-quantum-safe@080c3dd), where previously `openssl@3` pointed to `openssl v3.0.x` which was causing errors trying to build oqs-provider. So the change was made to specify `openssl@3.1`. OpenSSL v3.2 was released last week and the circleci jobs for macOS started failing since `openssl@3.1` is no longer available to install using homebrew. Instead the following are the options: `openssl@3` (which points to the current stable version, v3.2), `openssl@3.0` and `openssl@1.1`. Changes made in this PR include: - pointing the openssl version back to `openssl@3` since it now points to the latest 3.2 - a small doc change to the CONTRIBUTING doc to update the circleci command to run a specific job locally. (In the latest version (currently vv0.1.29314), this command does not have the --job flag) Signed-off-by: Felipe Ventura <felipe.ventura@entrust.com>
This PR updates the openssl version to be installed for testing macOS builds
The circleci config file currently points to openssl@3.1 to install openssl for macOS. This change was made as part of the following PR, where previously
openssl@3
pointed toopenssl v3.0.x
which was causing errors trying to build oqs-provider. So the change was made to specifyopenssl@3.1
. OpenSSL v3.2 was released last week and the circleci jobs for macOS started failing sinceopenssl@3.1
is no longer available to install using homebrew. Instead the following are the options:openssl@3
(which points to the current stable version, v3.2),openssl@3.0
andopenssl@1.1
.Changes made in this PR include:
openssl@3
since it now points to the latest 3.2