Ac/clean up and fixes (#981)

* Remove beacons micro-app as default Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fix custom compose failing check due to empty string Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
open-rmf · Aug 1, 2024 · 6829365 · 6829365
1 parent 6ab39e9
commit 6829365
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/packages/dashboard/src/components/robots/robots-workspace.tsx b/packages/dashboard/src/components/robots/robots-workspace.tsx
@@ -2,19 +2,17 @@ import { WorkspaceState } from '../workspace';
 
 export const robotsWorkspace: WorkspaceState = {
   layout: [
-    { i: 'robots', x: 0, y: 0, w: 7, h: 3 },
-    { i: 'map', x: 8, y: 0, w: 5, h: 9 },
-    { i: 'doors', x: 0, y: 0, w: 7, h: 3 },
-    { i: 'lifts', x: 0, y: 0, w: 7, h: 3 },
-    { i: 'beacons', x: 0, y: 0, w: 7, h: 3 },
-    { i: 'mutexGroups', x: 8, y: 0, w: 5, h: 3 },
+    { i: 'robots', x: 0, y: 0, w: 7, h: 4 },
+    { i: 'map', x: 8, y: 0, w: 5, h: 8 },
+    { i: 'doors', x: 0, y: 0, w: 7, h: 4 },
+    { i: 'lifts', x: 0, y: 0, w: 7, h: 4 },
+    { i: 'mutexGroups', x: 8, y: 0, w: 5, h: 4 },
   ],
   windows: [
     { key: 'robots', appName: 'Robots' },
     { key: 'map', appName: 'Map' },
     { key: 'doors', appName: 'Doors' },
     { key: 'lifts', appName: 'Lifts' },
-    { key: 'beacons', appName: 'Beacons' },
     { key: 'mutexGroups', appName: 'Mutex Groups' },
   ],
 };
diff --git a/packages/react-components/lib/tasks/create-task.tsx b/packages/react-components/lib/tasks/create-task.tsx
@@ -373,7 +373,7 @@ export function CreateTaskForm({
       if (req === null) {
         console.error(`Failed to create task request for definition ID: [${definitionId}]`);
       }
-      if (desc && req) {
+      if (desc !== undefined && req !== null) {
         validTasks.push(supportedTask);
 
         if (!defaultTaskDescription && !defaultTaskRequest) {