Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ac/clean up and fixes #981

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Ac/clean up and fixes #981

merged 2 commits into from
Aug 1, 2024

Conversation

aaronchongth
Copy link
Member

What's new

  • Remove unused beacon micro-app by default
  • Fix missing custom compose task in form due to empty string as description

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

@aaronchongth
Remove beacons micro-app as default
9a454d6 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth
Fix custom compose failing check due to empty string
a88c326 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit 6829365 into koonpeng/hammer-jazzy-base Aug 1, 2024
3 checks passed
@aaronchongth aaronchongth deleted the ac/clean-up-and-fixes branch August 1, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koonpeng koonpeng koonpeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronchongth @koonpeng