Direct dispatch to fleet or robot #1004
Conversation
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…scheduled fleet task Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…d comments Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
| @@ -331,7 +350,8 @@ export const TaskSchedule = () => { | |||
| setEventScope(EventScopes.CURRENT); | |||
| AppEvents.refreshTaskSchedule.next(); | |||
| }} | |||
| submitTasks={submitTasks} | |||
| onDispatchTask={dispatchTaskCallback} | |||
| onScheduleTask={editScheduledTaskCallback} | |||
There was a problem hiding this comment.
Can we use the same code for both this and the appbar? The way it is now has quite abit of code smell, onScheduleTask has different meaning depending on the context, we need to decouple it, my ideas are either
- Have 2 different callback explicitly, for create and edit, then both here and appbar can use the same code.
- Use different components, i.e. have a
EditTaskcomponent, it can useCreateTaskForminternally but with some differences in behavior and text.
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
| onScheduleTask?(task: TaskRequest, schedule: Schedule): Promise<void>; | ||
| onEditScheduleTask?(task: TaskRequest, schedule: Schedule): Promise<void>; |
There was a problem hiding this comment.
Add docs for these 2 props and schedule. iiuc, only onEditScheduleTask is used in "edit" mode, which is controlled by the schedule prop and onScheduleTask is used otherwise. They are mutually exclusive and will never be used together.
Better would be to refactor this to use the micro app hooks, the task form should be able to handle all the api calls itself and all these callbacks should be able to be replaced with a single onClose callback. But I leave it up to you if you want to do the refactor now.
There was a problem hiding this comment.
they technically can be used together, just that we choose not to provide a callback in whichever place we are creating a task form, i.e. the edit schedule component can also provide onScheduleTask but because of the function itself, we choose not to provide it.
yeah using hooks will be ideal, I will help look into it when we finally merge react components and dashboard
edit: more specifically, buttons will be rendered, based on the availability of these callback functions, if both are provided, both buttons will be rendered.
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
What's new
fleet-robot-2024-08-30_14.11.35.mp4
Self-checks