-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct dispatch to fleet or robot #1004
Merged
Merged
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
3213eea
Basic implementation of priority based on legacy implementation
aaronchongth caa8fd7
Use icons for favorite
aaronchongth f9b2efa
Fix warning time, use switch and made buttons nicer
aaronchongth 2bdd4d3
To display priority
aaronchongth 77950be
Lint
aaronchongth 09d6e57
Merge branch 'main' into feat/labels-priority-schedule
aaronchongth a6a4e41
Helper function to handle null and undefined priority, clean up creation
aaronchongth 0703b77
Use switch for priority, flip low priority icon
aaronchongth 6a5ff5a
Remove getDefaultTaskPriorty
aaronchongth ce848a2
Basic implementation working, still with frontend errors
aaronchongth ca9ecf9
Fix component render sequence issues
aaronchongth a29954b
Lint
aaronchongth a310646
Merge branch 'main' into feature/fleet-robot-selection
aaronchongth cdf7fba
Fix capitalization, disable scheuling for robot dispatch, allow edit …
aaronchongth 35f92a8
Comments and consolidate logs
aaronchongth d9c8fba
Slight tree view for robots, change dropdown size, use const enum
aaronchongth 7ba2064
Refactor dispatch and schedule callbacks, fix edit schedule event, ad…
aaronchongth bfd018a
Merge branch 'main' into feature/fleet-robot-selection
aaronchongth ad263a0
Remove stale print
aaronchongth 3692aa7
lint
aaronchongth 4dece1e
Make task form more generically named, new callback for schedule editing
aaronchongth adb317f
Merge branch 'main' into feature/fleet-robot-selection
aaronchongth 9c592af
Document props
aaronchongth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the same code for both this and the appbar? The way it is now has quite abit of code smell,
onScheduleTask
has different meaning depending on the context, we need to decouple it, my ideas are eitherEditTask
component, it can useCreateTaskForm
internally but with some differences in behavior and text.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4dece1e