-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Refector dashboard to a dashboard framework library. #1007
Conversation
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
658930e
to
549b42e
Compare
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
549b42e
to
3b4c1e9
Compare
…components Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
b8a6ebc
to
4c0de1c
Compare
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
…components Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
…components Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
…components Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for putting this together! I have a few comments and nitpicks, here and there, but overall it's looking great!
This is not part of the diff, so I'll write it out here, our codecov.yml
still references react-components
At this point, you should be able to follow the [demo dashboard example](../examples/demo/main.tsx). You may need to install additional deps if you want to use the same fonts as the demo. | ||
|
||
```bash | ||
pnpm add -w @fontsource/roboto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pnpm add -w @fontsource/roboto | |
pnpm add @fontsource/roboto |
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
8c36f1e
to
7f2f570
Compare
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
…components Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Most of the instructions are working fine, however it looks like the demo-dashboard
docker image is broken. I tested with
built with the fixes I listed,
docker build -t kp-dashboard:latest --build-arg "BRANCH=koonpeng/merge-react-components" demo-dashboard/
run,
docker run --network host -it --rm -e RMF_SERVER_URL=http://localhost:8000 -e TRAJECTORY_SERVER_URL=ws://localhost:8006 kp-dashboard:latest
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
Signed-off-by: Teo Koon Peng <teokoonpeng@gmail.com>
I had to pin node to 20 because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the massive refactor! LGTM
This is built on top of koonpeng/microapps-v2. This builds upon the architecture and refactor the existing dashboard into a dashboard framework library, the existing dashboard is now a demo example and can be started with
pnpm start:example examples/demo
. There is also a custom theme example using the awesome nord theme.