-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete the entire recurring event or only the selected event #742
Conversation
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
…dule Signed-off-by: angatupyry <fierrofenix@gmail.com>
… or not the curretn date is include in the array of except_dates Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #742 +/- ##
==========================================
- Coverage 54.64% 54.26% -0.39%
==========================================
Files 263 263
Lines 6524 6581 +57
Branches 862 870 +8
==========================================
+ Hits 3565 3571 +6
- Misses 2819 2870 +51
Partials 140 140
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this epic feature! I'll test the feature over the weekend for multiple days to check that scheduling and deletion is working. For now, I've left some comments, let me know what you think!
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
Signed-off-by: angatupyry <fierrofenix@gmail.com>
…e and understandable. Signed-off-by: angatupyry <fierrofenix@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! Thanks! LGTM
What's new
except_dates
. An array that stores the dates that the user does not want a job to run.chrome-capture-2023-7-22.webm
chrome-capture-2023-7-22.1.webm
Self-checks
Discussion