Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and update task related features #893

Closed
wants to merge 4 commits into from
Closed

Fix and update task related features #893

wants to merge 4 commits into from

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Feb 2, 2024

What's new

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9567672) 50.48% compared to head (ae7dda5) 51.01%.

Files Patch % Lines
packages/dashboard/src/components/appbar.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
+ Coverage   50.48%   51.01%   +0.53%     
==========================================
  Files         283      283              
  Lines        7179     7092      -87     
  Branches      960      963       +3     
==========================================
- Hits         3624     3618       -6     
+ Misses       3407     3326      -81     
  Partials      148      148              
Flag Coverage Δ
api-server 78.75% <ø> (ø)
dashboard 16.66% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth changed the title Fix/tasks Fix and update task related features Feb 3, 2024
@aaronchongth aaronchongth marked this pull request as draft February 3, 2024 04:02
@aaronchongth
Copy link
Member Author

Closing in favor of #925

@aaronchongth aaronchongth deleted the fix/tasks branch March 28, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant