Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hammer/demo tasks #925

Merged
merged 32 commits into from
Jun 26, 2024
Merged

Hammer/demo tasks #925

merged 32 commits into from
Jun 26, 2024

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Mar 28, 2024

What's new

  • Introduced patrol, delivery and clean back
  • Refactored each task to it's own file to handle its own description and form
  • Configurable list of supported tasks, order of task is respected in the menu
  • Task name remapping
  • Using task definition ID to identify task type
  • Allow configuring of request category via task definition

Here is how the rmf-web/packages/dashboard/src/assets/resources/main.json can look like,

{
    ...,
    "supportedTasks": [
        {
            "taskDefinitionId": "delivery_pickup",
            "taskDisplayName": "Delivery - 1:1",
            "requestCategory": "compose"
        },
        {
            "taskDefinitionId": "delivery_sequential_lot_pickup",
            "taskDisplayName": "Delivery - Sequential lot pick up",
            "requestCategory": "compose"
        },
        {
            "taskDefinitionId": "delivery_area_pickup",
            "taskDisplayName": "Delivery - Area pick up",
            "requestCategory": "compose"
        },
        {
            "taskDefinitionId": "patrol",
            "taskDisplayName": "Patrol",
            "requestCategory": "patrol"
        },
        {
            "taskDefinitionId": "custom_compose",
            "taskDisplayName": "Custom Compose Task",
            "requestCategory": "compose"
        }
    ]
    ...
}

image

image

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 9.66767% with 299 lines in your changes missing coverage. Please review.

Project coverage is 26.37%. Comparing base (fe0e808) to head (eb9aeda).
Report is 93 commits behind head on deploy/hammer.

Current head eb9aeda differs from pull request most recent head ce58404

Please upload reports for the commit ce58404 to get more accurate results.

Files Patch % Lines
...act-components/lib/tasks/types/delivery-custom.tsx 23.07% 100 Missing ⚠️
...ackages/react-components/lib/tasks/create-task.tsx 0.00% 57 Missing ⚠️
...ckages/react-components/lib/tasks/types/patrol.tsx 2.70% 36 Missing ⚠️
packages/react-components/lib/tasks/types/utils.ts 0.00% 29 Missing ⚠️
...act-components/lib/tasks/types/delivery-simple.tsx 0.00% 28 Missing ⚠️
...ackages/react-components/lib/tasks/types/clean.tsx 0.00% 24 Missing ⚠️
...eact-components/lib/tasks/types/custom-compose.tsx 6.25% 15 Missing ⚠️
...hboard/src/components/tasks/task-schedule-utils.ts 0.00% 8 Missing ⚠️
...s/dashboard/src/components/tasks/task-schedule.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           deploy/hammer     #925       +/-   ##
==================================================
- Coverage          49.35%   26.37%   -22.99%     
==================================================
  Files                285      163      -122     
  Lines               7564     5377     -2187     
  Branches            1050     1419      +369     
==================================================
- Hits                3733     1418     -2315     
- Misses              3682     3760       +78     
- Partials             149      199       +50     
Flag Coverage Δ
api-server ?
dashboard 13.70% <0.00%> (-1.37%) ⬇️
react-components 42.61% <9.96%> (-5.47%) ⬇️
rmf-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
packages/react-components/lib/tasks/types/utils.ts Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/types/clean.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth marked this pull request as ready for review June 4, 2024 09:14
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/dashboard/src/managers/resource-manager.ts Outdated Show resolved Hide resolved
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…ource manager level

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit 105628b into deploy/hammer Jun 26, 2024
3 checks passed
@aaronchongth aaronchongth deleted the hammer/demo-tasks branch June 26, 2024 06:57
aaronchongth added a commit that referenced this pull request Jul 3, 2024
* Moved custom deliveries to separate file naively and import naively

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved patrol

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved custom-compose

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Added clean and delivery

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Added delivery, renamed to SimpleDelivery

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Clean task added

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved delivery-custom tests, added return type for forms

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Configurable supported tasks and name remapping

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Changed directory to types, since it doesn't just handle descriptions

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix test imports

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Using temporary task definition

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactoring new rename changes

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Clean up

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Removed problematic and unsused component and test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Updating pnpm version in github workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Reverting update to pnpm version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix build now that we use key value strings for labels

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactored last parts of hard coding categories and rendering forms

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactor callback names and error handling for misconfigs

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Display error as well

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fixed more checks and failures

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Split configuration and definition, only handle configurations in resource manager level

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Not using object as a type

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address feedback

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Render using validTasks instead

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Use useMemo

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
(cherry picked from commit 105628b)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth added a commit that referenced this pull request Jul 4, 2024
* Hammer/demo tasks (#925)

* Moved custom deliveries to separate file naively and import naively

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved patrol

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved custom-compose

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Added clean and delivery

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Added delivery, renamed to SimpleDelivery

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Clean task added

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved delivery-custom tests, added return type for forms

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Configurable supported tasks and name remapping

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Changed directory to types, since it doesn't just handle descriptions

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix test imports

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Using temporary task definition

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactoring new rename changes

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Clean up

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Removed problematic and unsused component and test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Updating pnpm version in github workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Reverting update to pnpm version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix build now that we use key value strings for labels

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactored last parts of hard coding categories and rendering forms

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactor callback names and error handling for misconfigs

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Display error as well

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fixed more checks and failures

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Split configuration and definition, only handle configurations in resource manager level

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Not using object as a type

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address feedback

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Render using validTasks instead

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Use useMemo

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* First iteration of double compose delivery task

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint and fix dispatck task insert emergency lots workaround

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix favorite task confirmation text field, add more tests

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert addition of double compose delivery to resource manager

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Small UI tweaks to form field widths

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix tests, grid containers for warn time

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address feedback

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth added a commit that referenced this pull request Jul 9, 2024
* First iteration of generic alerts

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Route for unresponded alerts

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Basic location complete post route for task

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Tests for alert routes

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Test for location complete route

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint and tests

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Basic implementation

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Basic task based alerts working as expected

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Only display and list alerts that have display true

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Add doc to location_complete route about instability

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactored alert db interactions to repository, with lru cache for location alerts checking

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Regenerated docs and return early on gateway last location checking

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint and better typing with static methods

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Hammer/generic alerts without location (#951)

* First round of cleanup

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Regenerate API

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Hammer/demo tasks (#925)

* Moved custom deliveries to separate file naively and import naively

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved patrol

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved custom-compose

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Added clean and delivery

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Added delivery, renamed to SimpleDelivery

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Clean task added

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved delivery-custom tests, added return type for forms

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Configurable supported tasks and name remapping

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Changed directory to types, since it doesn't just handle descriptions

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix test imports

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Using temporary task definition

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactoring new rename changes

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Clean up

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Removed problematic and unsused component and test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Updating pnpm version in github workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Reverting update to pnpm version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix build now that we use key value strings for labels

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactored last parts of hard coding categories and rendering forms

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactor callback names and error handling for misconfigs

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Display error as well

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fixed more checks and failures

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Split configuration and definition, only handle configurations in resource manager level

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Not using object as a type

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address feedback

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Render using validTasks instead

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Use useMemo

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Update ros2 pydantic messages, fix tests

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert update of pnpm lock file

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Use specific exceptions and more clean up

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert "Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble"

This reverts commit 1fd22ee.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Update pnpm version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Setup pnpm and node manually

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Using HOME env var of runner

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address feedback on frontend

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address comments that don't break behavior

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Started generic exceptions

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Proper db schema for alert request and response

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Updated alerts model, frontend tweaks for subscription, using pagination for unackw query, updated API

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Attempt to setup minimal RMF during bootstrap step

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix mistake on ci path

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert CI changes

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Updated API, renamed event to pushAlert, filter before

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth added a commit that referenced this pull request Jul 22, 2024
* First iteration of generic alerts

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Route for unresponded alerts

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Basic location complete post route for task

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Tests for alert routes

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Test for location complete route

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint and tests

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Basic implementation

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Basic task based alerts working as expected

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Only display and list alerts that have display true

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Add doc to location_complete route about instability

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactored alert db interactions to repository, with lru cache for location alerts checking

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Regenerated docs and return early on gateway last location checking

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint and better typing with static methods

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Hammer/generic alerts without location (#951)

* First round of cleanup

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Regenerate API

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Hammer/demo tasks (#925)

* Moved custom deliveries to separate file naively and import naively

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved patrol

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved custom-compose

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Added clean and delivery

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Added delivery, renamed to SimpleDelivery

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Clean task added

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved delivery-custom tests, added return type for forms

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Configurable supported tasks and name remapping

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Changed directory to types, since it doesn't just handle descriptions

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix test imports

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Using temporary task definition

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactoring new rename changes

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Clean up

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Removed problematic and unsused component and test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Updating pnpm version in github workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Reverting update to pnpm version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix build now that we use key value strings for labels

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactored last parts of hard coding categories and rendering forms

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactor callback names and error handling for misconfigs

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Display error as well

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fixed more checks and failures

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Split configuration and definition, only handle configurations in resource manager level

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Not using object as a type

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address feedback

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Render using validTasks instead

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Use useMemo

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Update ros2 pydantic messages, fix tests

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert update of pnpm lock file

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Use specific exceptions and more clean up

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert "Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble"

This reverts commit 1fd22ee.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Update pnpm version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Setup pnpm and node manually

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Using HOME env var of runner

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address feedback on frontend

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address comments that don't break behavior

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Started generic exceptions

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Proper db schema for alert request and response

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Updated alerts model, frontend tweaks for subscription, using pagination for unackw query, updated API

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Attempt to setup minimal RMF during bootstrap step

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix mistake on ci path

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert CI changes

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Updated API, renamed event to pushAlert, filter before

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
(cherry picked from commit 090dd9b)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth added a commit that referenced this pull request Aug 6, 2024
* Hammer/demo tasks (#925)

* Moved custom deliveries to separate file naively and import naively

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved patrol

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved custom-compose

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Added clean and delivery

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Added delivery, renamed to SimpleDelivery

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Clean task added

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved delivery-custom tests, added return type for forms

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Configurable supported tasks and name remapping

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Changed directory to types, since it doesn't just handle descriptions

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix test imports

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Using temporary task definition

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactoring new rename changes

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Clean up

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Removed problematic and unsused component and test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Updating pnpm version in github workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Reverting update to pnpm version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix build now that we use key value strings for labels

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactored last parts of hard coding categories and rendering forms

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactor callback names and error handling for misconfigs

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Display error as well

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fixed more checks and failures

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Split configuration and definition, only handle configurations in resource manager level

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Not using object as a type

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address feedback

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Render using validTasks instead

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Use useMemo

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* First iteration of double compose delivery task

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint and fix dispatck task insert emergency lots workaround

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix favorite task confirmation text field, add more tests

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert addition of double compose delivery to resource manager

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Small UI tweaks to form field widths

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix tests, grid containers for warn time

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address feedback

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
(cherry picked from commit 3649b5e)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth added a commit that referenced this pull request Aug 6, 2024
* Hammer/demo tasks (#925)

* Moved custom deliveries to separate file naively and import naively

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved patrol

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved custom-compose

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Added clean and delivery

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Added delivery, renamed to SimpleDelivery

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Clean task added

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Moved delivery-custom tests, added return type for forms

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Configurable supported tasks and name remapping

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Changed directory to types, since it doesn't just handle descriptions

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix test imports

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Using temporary task definition

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactoring new rename changes

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Clean up

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Removed problematic and unsused component and test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Updating pnpm version in github workflow

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Reverting update to pnpm version

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix build now that we use key value strings for labels

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactored last parts of hard coding categories and rendering forms

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Refactor callback names and error handling for misconfigs

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Display error as well

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fixed more checks and failures

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Split configuration and definition, only handle configurations in resource manager level

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Not using object as a type

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address feedback

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Render using validTasks instead

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Use useMemo

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* First iteration of double compose delivery task

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Lint and fix dispatck task insert emergency lots workaround

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix favorite task confirmation text field, add more tests

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Revert addition of double compose delivery to resource manager

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Small UI tweaks to form field widths

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Fix tests, grid containers for warn time

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

* Address feedback

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>

---------

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
(cherry picked from commit 3649b5e)
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants