-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use task request labels to encode information required by dashboard #912
Conversation
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…ting custom tasks Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…s be compose, display description for short description Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…cription assumptions Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
… request is saved Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## deploy/hammer #912 +/- ##
=================================================
- Coverage 49.35% 46.34% -3.01%
=================================================
Files 285 299 +14
Lines 7564 8681 +1117
Branches 1050 1384 +334
=================================================
+ Hits 3733 4023 +290
- Misses 3682 4455 +773
- Partials 149 203 +54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
* Getting ScheduledTask as well Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Handle schedules as well Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * lint Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
packages/api-server/api_server/models/migrate/migrate_db_912.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
… api-client Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…rom the state, instead of the request Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…ate when fav task is clicked Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Hammer/fix favorite with labels
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The api-server should eventually treat the labels as black boxes, i.e. there should be no models for them. For that to happen, we need to support querying and sorting the labels in a generic way.
I can work on it after this is merged, but in order to avoid more migration hell, we should prepare the labels in a new table in this PR.
…lds for sorting and filtering Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
…nd saving Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
What's new
Requires open-rmf/rmf_ros2#328 and #903
This PR adds
TaskBookingLabel
to be used by frontend dashboards to encode additional information required for rendering.None
for now).task_definition_id
field toTaskFavorite
,TaskState
,ScheduledTask
)Migration (postgres)
Backup database, enter database
Handling additional field in
TaskFavorite
,Migrate the rest of the models
Self-checks