Hammer/generic alerts without location #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth
added a commit
that referenced
this pull request
Jul 9, 2024
* First iteration of generic alerts Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Route for unresponded alerts Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Basic location complete post route for task Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Tests for alert routes Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Test for location complete route Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint and tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Basic implementation Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Basic task based alerts working as expected Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Only display and list alerts that have display true Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Add doc to location_complete route about instability Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Refactored alert db interactions to repository, with lru cache for location alerts checking Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Regenerated docs and return early on gateway last location checking Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint and better typing with static methods Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Hammer/generic alerts without location (#951) * First round of cleanup Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Regenerate API Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Hammer/demo tasks (#925) * Moved custom deliveries to separate file naively and import naively Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Moved patrol Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Moved custom-compose Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added clean and delivery Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added delivery, renamed to SimpleDelivery Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Clean task added Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Moved delivery-custom tests, added return type for forms Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Configurable supported tasks and name remapping Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Changed directory to types, since it doesn't just handle descriptions Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fix test imports Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Using temporary task definition Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Refactoring new rename changes Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Clean up Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Removed problematic and unsused component and test Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Updating pnpm version in github workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Reverting update to pnpm version Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fix build now that we use key value strings for labels Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Refactored last parts of hard coding categories and rendering forms Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Refactor callback names and error handling for misconfigs Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Display error as well Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fixed more checks and failures Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Split configuration and definition, only handle configurations in resource manager level Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Not using object as a type Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Address feedback Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Render using validTasks instead Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Use useMemo Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Update ros2 pydantic messages, fix tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Revert update of pnpm lock file Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Use specific exceptions and more clean up Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Revert "Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble" This reverts commit 1fd22ee. Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Update pnpm version Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Setup pnpm and node manually Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Using HOME env var of runner Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Address feedback on frontend Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Address comments that don't break behavior Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Started generic exceptions Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Proper db schema for alert request and response Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Updated alerts model, frontend tweaks for subscription, using pagination for unackw query, updated API Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Attempt to setup minimal RMF during bootstrap step Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fix mistake on ci path Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fix workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Revert CI changes Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Updated API, renamed event to pushAlert, filter before Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth
added a commit
that referenced
this pull request
Jul 22, 2024
* First iteration of generic alerts Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Route for unresponded alerts Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Basic location complete post route for task Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Tests for alert routes Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Test for location complete route Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint and tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Basic implementation Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Basic task based alerts working as expected Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Only display and list alerts that have display true Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Add doc to location_complete route about instability Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Refactored alert db interactions to repository, with lru cache for location alerts checking Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Regenerated docs and return early on gateway last location checking Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint and better typing with static methods Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Hammer/generic alerts without location (#951) * First round of cleanup Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Regenerate API Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Hammer/demo tasks (#925) * Moved custom deliveries to separate file naively and import naively Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Moved patrol Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Moved custom-compose Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added clean and delivery Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Added delivery, renamed to SimpleDelivery Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Clean task added Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Moved delivery-custom tests, added return type for forms Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Configurable supported tasks and name remapping Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Changed directory to types, since it doesn't just handle descriptions Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fix test imports Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Using temporary task definition Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Refactoring new rename changes Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Clean up Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Removed problematic and unsused component and test Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Updating pnpm version in github workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Reverting update to pnpm version Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fix build now that we use key value strings for labels Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Refactored last parts of hard coding categories and rendering forms Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Refactor callback names and error handling for misconfigs Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Display error as well Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fixed more checks and failures Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Split configuration and definition, only handle configurations in resource manager level Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Not using object as a type Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Address feedback Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Render using validTasks instead Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Use useMemo Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Update ros2 pydantic messages, fix tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Revert update of pnpm lock file Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Lint Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Use specific exceptions and more clean up Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Revert "Port CI fixes from #955 but targeting ubuntu 22 and ROS 2 Humble" This reverts commit 1fd22ee. Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Update pnpm version Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Setup pnpm and node manually Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Using HOME env var of runner Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Address feedback on frontend Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Address comments that don't break behavior Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Started generic exceptions Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Proper db schema for alert request and response Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Updated alerts model, frontend tweaks for subscription, using pagination for unackw query, updated API Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Attempt to setup minimal RMF during bootstrap step Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fix mistake on ci path Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Fix workflow Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Revert CI changes Signed-off-by: Aaron Chong <aaronchongth@gmail.com> * Updated API, renamed event to pushAlert, filter before Signed-off-by: Aaron Chong <aaronchongth@gmail.com> --------- Signed-off-by: Aaron Chong <aaronchongth@gmail.com> (cherry picked from commit 090dd9b) Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new