Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New alert messages #71

Merged
merged 3 commits into from
Jun 25, 2024
Merged

New alert messages #71

merged 3 commits into from
Jun 25, 2024

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented May 14, 2024

New feature implementation

Implemented feature

New messages that allow custom interactions to arise from the robots, fleets or other parts of the system, namely alerts, notifications, user interactions, etc

  • Alert
  • AlertParameter
  • AlertResponse

Example usage

This can hopefully extend to many more cases, other than these 3 examples provided

Case 1

  • Fleet adapters with custom perform_actions will require user input or responses for certain decisions, can publish an alert with all the possible responses listed
  • API server picks it up and prompts the users on the frontend
  • User chooses a response
  • API server will publish the response back down to the fleet adapter

Case 2

  • Fleet adapters wishes to inform users something has happened in the form of a notification (info,warning or error), with no user response required

Case 3

  • Fleet adapters with custom perform_actions will require input or responses from other parts of the system (non-human), an alert can be sent out with it toggled not to be displayed
  • The other system can respond using the response message as well

@xiyuoh
Copy link
Member

xiyuoh commented Jun 18, 2024

LGTM, have tested it and it is comprehensive enough to contain the different types of information we would need to publish messages between the fleet adapter and RMF web.

xiyuoh
xiyuoh previously approved these changes Jun 18, 2024
@aaronchongth aaronchongth marked this pull request as draft June 18, 2024 09:40
@aaronchongth aaronchongth marked this pull request as ready for review June 20, 2024 05:39
rmf_task_msgs/msg/Alert.msg Outdated Show resolved Hide resolved
@aaronchongth aaronchongth requested a review from xiyuoh June 24, 2024 06:54
@aaronchongth aaronchongth changed the title New fleet alert messages New alert messages Jun 24, 2024
Copy link
Member

@xiyuoh xiyuoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit dd2951d into main Jun 25, 2024
1 check passed
@aaronchongth aaronchongth deleted the fleet-alerts branch June 25, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants